Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap to stable v2 #2087

Closed
9 of 10 tasks
philippkuehn opened this issue Oct 26, 2021 · 22 comments
Closed
9 of 10 tasks

Roadmap to stable v2 #2087

philippkuehn opened this issue Oct 26, 2021 · 22 comments

Comments

@philippkuehn
Copy link
Contributor

philippkuehn commented Oct 26, 2021

Hey, it’s amazing how far tiptap v2 beta has already made it. Thanks a lot for your support. 🙌

I'm trying to make a list here of features we still want to implement until stable v2.
This list is not final. If you have any wishes, please comment below.

Features

Breaking Changes

QA

  • Add at least one test for every example

Docs

Misc

  • Switch setup from yarn to npm
@philippkuehn philippkuehn added Type: Feature The issue or pullrequest is a new feature and removed Type: Feature The issue or pullrequest is a new feature labels Oct 26, 2021
@philippkuehn philippkuehn pinned this issue Oct 26, 2021
@sereneinserenade
Copy link
Contributor

sereneinserenade commented Oct 26, 2021

Will #2075 be a part of stable v2?

edit: people searching for search-n-replace extension, take a look at https://github.com/sereneinserenade/tiptap-search-n-replace-demo

@mhmttosun
Copy link

mhmttosun commented Oct 26, 2021

Will more complete image extension (like resizeable, custom upload, Caption, paste image) be part of stable version?

@cadars
Copy link
Contributor

cadars commented Oct 26, 2021

My wish would be to improve the general text editing experience: a more consistent behaviour to be able to exit all node types, and delete them with backspace when empty?

Some examples:

  • when last in the document, <hr> creates an extra node, table uses the gapcursor extension, and code blocks are only escapable with shift + enter (which is not possible on mobile, so the trailing node extension is needed).
  • when first in the document, backspace can delete an empty blockquote, but not an empty heading.

@hanspagel
Copy link
Contributor

We won’t tie the stable release to any extension release, but we’ll definitely focus more on extension development for the next months. ✌️

@rezaffm
Copy link

rezaffm commented Oct 28, 2021

Great to see that it is progressing. Working with the current version already in production and all good so far.

@pdmwxy
Copy link

pdmwxy commented Oct 28, 2021

We won’t tie the stable release to any extension release, but we’ll definitely focus more on extension development for the next months. ✌️

My wish is to add the function of change tracking. At present, the project urgently needs this function. Can you reply whether there is a plan to add this function, or whether it is available in the pro version?

@philippkuehn philippkuehn mentioned this issue Nov 10, 2021
@yellow1912
Copy link

I think you need to document these BreakingChanges and what to do as well. I had to track down the issues to understand what went wrong and the changes needed.

@emma-campbell

This comment has been minimized.

@tylerforesthauser

This comment has been minimized.

@emma-campbell

This comment has been minimized.

@philippkuehn

This comment has been minimized.

@emma-campbell

This comment has been minimized.

@rezaffm

This comment has been minimized.

@emma-campbell

This comment has been minimized.

@hanspagel
Copy link
Contributor

Thanks for sharing, but this is really off topic. If there are more questions related to title/subtitle documents, please open a new question under discussions.

@rezaffm
Copy link

rezaffm commented Nov 18, 2021

True, looking forward to your stable release guys

@felix-berlin
Copy link

Will more complete image extension (like resizeable, custom upload, Caption, paste image) be part of stable version?

That's exactly what I want too!

@sereneinserenade
Copy link
Contributor

Here's the repo https://github.com/sereneinserenade/tiptap-media-resize. You can try it out here https://sereneinserenade.github.io/tiptap-media-resize/ and here's a demo video.

Screen.Recording.2022-07-09.at.23.20.25.mov

@creatorrr
Copy link

Thanks for the awesome work, @philippkuehn ! Quick question: I got a bunch of errors from the typescript compiler when I tried building my tiptap project for @tiptap/core. Still trying to figure out if I am doing something wrong but I thought I'd report these anyway.

(...clipped)

node_modules/@tiptap/core/src/helpers/isList.ts:20:59 - error TS2339: Property 'group' does not exist on type 'NodeConfig<any, any>'.

20   const group = callOrReturn(getExtensionField<NodeConfig['group']>(extension, 'group', context))
                                                             ~~~~~~~

node_modules/@tiptap/core/src/pasteRules/nodePasteRule.ts:31:12 - error TS2339: Property 'deleteRange' does not exist on type 'ChainedCommands'.

31           .deleteRange(range)
              ~~~~~~~~~~~


Found 190 errors in 61 files.

Errors  Files
     1  node_modules/@tiptap/core/src/Editor.ts:103
    28  node_modules/@tiptap/core/src/Extension.ts:70
    18  node_modules/@tiptap/core/src/ExtensionManager.ts:57
    28  node_modules/@tiptap/core/src/Mark.ts:76
    29  node_modules/@tiptap/core/src/Node.ts:76
     2  node_modules/@tiptap/core/src/NodeView.ts:243
     1  node_modules/@tiptap/core/src/commands/blur.ts:14
     1  node_modules/@tiptap/core/src/commands/clearContent.ts:14
     1  node_modules/@tiptap/core/src/commands/clearNodes.ts:16
     2  node_modules/@tiptap/core/src/commands/command.ts:5
     1  node_modules/@tiptap/core/src/commands/createParagraphNear.ts:16
     1  node_modules/@tiptap/core/src/commands/deleteNode.ts:17
     1  node_modules/@tiptap/core/src/commands/deleteRange.ts:14
     1  node_modules/@tiptap/core/src/commands/deleteSelection.ts:16

(...clipped)
npx tsc --version                                                                                                                                                      3s
Version 4.8.2

@bdbch bdbch unpinned this issue Sep 10, 2022
@bdbch
Copy link
Contributor

bdbch commented Sep 14, 2022

Hey @creatorrr what are your Tiptap package versions? It seems like you have some mismatching of Prosemirror versions going on which results in Typescript errors.

@bdbch
Copy link
Contributor

bdbch commented Sep 15, 2022

I am going to close this issue for now.

Everything from the original list for 2.0.0 is done by now, but I have found a few weird editor behaviors (thanks to @rfgamaral) that I would like to fix before 2.0.0 including weird joining of nodes when backspace or delete is used that is not in line with expected behaviors from Google Docs, Dropbox Paper and Co. (which are usually the solutions people would expect from a text editor).

We also have some open issues about NodeViews that we should fix before releasing a stable version.

We have a 2.0.0 Milestone for now and will plan out potential open issues for our stable release in there.

@bdbch bdbch closed this as completed Sep 15, 2022
@rfgamaral
Copy link
Contributor

rfgamaral commented Sep 15, 2022

Hey @bdbch, I want to propose a few additional issues for the v2.0.0 milestone. I am a bit biased on these, yes, but I believe that most of these are just as important for a stable v2. Please note that all the issues linked below have been closed by the stale bot, but they are still issues.

Most of them are related to the suggestion utility, which, IMO, needs a lot of improvement and is currently a bit buggy:

Then, a few others with lower priority:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests