Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When text align is default, don't add a style attribute #1251

Merged
merged 2 commits into from
May 11, 2021
Merged

When text align is default, don't add a style attribute #1251

merged 2 commits into from
May 11, 2021

Conversation

robguthrie
Copy link
Contributor

No description provided.

packages/extension-text-align/src/text-align.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@zcuric zcuric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, but please address these suggestions.

Co-authored-by: Zdravko Curic <zcuric@users.noreply.github.com>
@robguthrie
Copy link
Contributor Author

thanks for the tips

@zcuric
Copy link
Contributor

zcuric commented May 7, 2021

@philippkuehn LGTM :)

@klaasgeldof
Copy link

klaasgeldof commented May 10, 2021

Was running into issues with TextAlign today. Even if you don't touch the align buttons, it always sets a style attribute of text-align: left. Then when you use the value in your HTML, for example like this:

<div class="text-center">
    {{ $value }}
</div>

...the text is always left aligned.

This PR should fix this, so hopefully it gets merged soon 😉

@philippkuehn philippkuehn merged commit 8a245f5 into ueberdosis:main May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants