Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
useEditor
composable, theRef
that is returned observes changes on the Editor's own properties, causing any effects that referenceeditor
to trigger unnecessarily.Even though the Editor's constructor uses
markRaw
, usingref
wraps your value in an object and makes it reactive internally. You can see this happening here: https://github.com/vuejs/composition-api/blob/main/src/reactivity/ref.ts#L82The check for
isRaw
only happens on the parent, which in this case is the wrapper object.Using
shallowRef
instead allows us to create effects that trigger when the Editor is instantiated (in theonMounted
) while preventing reactivity of the Editor's properties. From the Vue docs: