Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editor to items prop in suggestion plugin #2082

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

philippkuehn
Copy link
Contributor

With this small breaking change, editor is added to the items prop in the suggestion plugin. This is useful because you can now access the new editor storage when filtering items.

Before:

Suggestion({
  char: '@',
  items: (query) => {
    // filter some items based on query
  },
  // ...
})

After:

Suggestion({
  char: '@',
  items: ({ editor, query }) => {
    // filter some items based on query
  },
  // ...
})

@philippkuehn philippkuehn merged commit a6f731a into main Oct 25, 2021
@philippkuehn philippkuehn deleted the feature/add-editor-prop-in-suggestion-plugin branch October 25, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant