Svelte Example: remove wrong type="context" tag
#2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example doesn't compile because in Svelte 3 there is no `type="context"`, there is only `context="module". Even if you use `context="module"` it is supposed to give an error because there is no `onMount` and `onDestroy` in module context. Removing this tag from the Script element will fix the issue.
|
✔️ Deploy Preview for tiptap-embed ready! 🔨 Explore the source changes: 72316a1 🔍 Inspect the deploy log: https://app.netlify.com/sites/tiptap-embed/deploys/61ae724da2fb900008d14222 😎 Browse the preview: https://deploy-preview-2240--tiptap-embed.netlify.app |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example doesn't compile because in Svelte 3 there is no
type="context", there is onlycontext="module". Even if you usecontext="module"it is supposed to give an error because there is noonMountandonDestroyin module context. Removing this tag from the Script element will fix the issue.