fix(core): insert PasteRule Node at matched position (#2942) #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
Info: Stale
|
@edlb could you get the latest main branch merged and check if the tests are still failing? |
edlb
force-pushed
the
fix/node-paste-rule-position
branch
from
ae11dc3
to
f0f03ea
Compare
github-actions
bot
removed
the
Info: Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to fix #2942
Using
nodePasteRulethe Node would be added at the end of the editor.This PR replaces
insertContentwithinsertContentAtto insert the Node at the matched position instead.