Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update alpine installation #3081

Merged
merged 2 commits into from
Aug 12, 2022
Merged

docs: update alpine installation #3081

merged 2 commits into from
Aug 12, 2022

Conversation

patrickbaber
Copy link
Contributor

The docs about the installation with Alpine.js is not compatible with version 3.

Should help with #1515

Also the default Vite port changed.

Thanks to @EasterPeanut

@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 6a33a37
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/62f6250ad42e48000a8bf8a3
😎 Deploy Preview https://deploy-preview-3081--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patrickbaber
Copy link
Contributor Author

patrickbaber commented Aug 12, 2022 •
edited
Loading

This is the preferred way to integrate external libraries with Alpine.js v3 as discussed here and here.

bdbch
bdbch approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@bdbch bdbch merged commit eb68f79 into main Aug 12, 2022
@bdbch bdbch deleted the docs/alpine-v3 branch August 12, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdbch bdbch bdbch approved these changes

@svenadlung svenadlung Awaiting requested review from svenadlung svenadlung is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickbaber @bdbch