🧹 Allow editor.setEditable to omit updates
#3301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bdbch
approved these changes
Oct 17, 2022
|
@bdbch I've resolved the lint errors. |
|
@bdbch we are looking forward for this to be merged as we are facing a similar problem while using the |
|
@ZaymonFC looks like this PR was already approved by |
|
Hey! Thanks @gethari - I restarted the cypress and lint tests and will see if we can merge this today. |
2 tasks
|
@bdbch can we get a new release with this changes please ? |
aliasliao
pushed a commit
to aliasliao/tiptap
that referenced
this pull request
May 24, 2023
* 🧹 Allow `editor.setEditable` to omit updates * 📚 Document change to `editor.setEditable`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #3289