Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove blur event listener from tippy element (#3365) #3366

Merged
merged 1 commit into from
Nov 4, 2022
Merged

fix: remove blur event listener from tippy element (#3365) #3366

merged 1 commit into from
Nov 4, 2022

Conversation

MihirGH
Copy link
Contributor

@MihirGH MihirGH commented Oct 28, 2022

Fixes: #3365
We are adding event listener for blur on tippy element but we aren't removing it during destroy
This PR adds the invocation to remove the said event listener.

@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 0ba5d29
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/635c060f6d2db00008ef466a
😎 Deploy Preview https://deploy-preview-3366--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdbch bdbch merged commit aca6c88 into ueberdosis:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in BubbleMenuView and FloatingMenuView
2 participants