Fix #3392 - Unexpected renderText() for contentful nodes #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mylesj
force-pushed
the
fix/duplicate-render-text
branch
from
4e1d546
to
c206552
Compare
bdbch
added
Status: Review
Category: Open Source
2 tasks
mylesj
force-pushed
the
fix/duplicate-render-text
branch
from
34439bd
to
9476ed6
Compare
|
Hey folks, can we have some input on this one please? I've just updated my branch and this still appears to be relevant. Can it be rolled into your release roadmap? |
bdbch
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is causing a number of downstream problems for me as it impacts multiple touch points, namely:
editor.getText()stateI had a go at patching it myself and this appears to be the simplest solution - it might raise the question of how deeply nested nodes should be handled but I think it is reasonable to assert that: any nodes with a custom text renderer are solely responsible for how their children are rendered.