Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Prosemirror Meta Package #3556

Merged
merged 42 commits into from
Feb 2, 2023
Merged

New Feature: Prosemirror Meta Package #3556

merged 42 commits into from
Feb 2, 2023

Conversation

bdbch
Copy link
Contributor

@bdbch bdbch commented Dec 16, 2022

Changes

This PR introduces a new @tiptap/pm package which includes all necessary prosemirror modules as a meta package that should resolve the dependencies of Tiptap.

This should resolve issues like #3529 #3497

Right now this PR waits for #3555 since this requires changes to our build process which need to be tested first.

This will allow access to prosemirror packages like this:

import { EditorState } from '@tiptap/pm/state'
import * as Tables from '@tiptap/pm/tables'

Open Todo

  • Check dependencies of tiptap packages & test if pm package resolves requirements correctly @bdbch
  • Resolve local typing issues with @tiptap/pm
  • Update documentation @bdbch
  • Update installation guides @bdbch
  • Add upgrade guides @bdbch
  • Resolve build & test issues
  • Reevaluate peer dependencies

@bdbch bdbch self-assigned this Dec 16, 2022
@netlify
Copy link

netlify bot commented Dec 16, 2022

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 13b2982
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/63dbe6af89aa140008acbf9b
😎 Deploy Preview https://deploy-preview-3556--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdbch bdbch changed the base branch from main to build-update December 16, 2022 15:25
@bdbch bdbch changed the title feat(pm): Prosemirror Meta Package New Feature: Prosemirror Meta Package Dec 16, 2022
Copy link
Contributor

@svenadlung svenadlung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really promising! Good work! Just left some typo improvements.

docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
packages/pm/README.md Outdated Show resolved Hide resolved
packages/pm/README.md Outdated Show resolved Hide resolved
packages/pm/README.md Outdated Show resolved Hide resolved
Base automatically changed from build-update to main January 25, 2023 09:19
@bdbch bdbch marked this pull request as ready for review February 2, 2023 11:12
docs/installation.md Outdated Show resolved Hide resolved
svenadlung
svenadlung previously approved these changes Feb 2, 2023
@bdbch bdbch merged commit f387ad3 into main Feb 2, 2023
@bdbch bdbch deleted the prosemirror-meta-package branch February 2, 2023 16:37
@jmamakeesic
Copy link

@bdbch It seems that starter-kit still needs to updated.
I tried importing the following extensions from starter-kit@2.0.0-beta.212 and I get the following errors:

@tiptap/starter-kit doesn't provide @tiptap/pm, requested by @tiptap/core
@tiptap/starter-kit doesn't provide @tiptap/pm, requested by @tiptap/extension-code-block
@tiptap/starter-kit doesn't provide @tiptap/pm, requested by @tiptap/extension-dropcursor
@tiptap/starter-kit doesn't provide @tiptap/pm, requested by @tiptap/extension-gapcursor
@tiptap/starter-kit doesn't provide @tiptap/pm, requested by @tiptap/extension-history
@tiptap/starter-kit doesn't provide @tiptap/pm, requested by @tiptap/extension-horizontal-rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants