add optionalSlashSlash to protocol options #3675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bdbch
requested changes
Feb 7, 2023
bdbch
previously approved these changes
Feb 7, 2023
bdbch
previously approved these changes
Feb 9, 2023
|
Looks good @taras-turchenko-moc could you resolve the conflict so we can merge this? |
…_protocol_options
|
@bdbch done |
|
Somewhy tests failed on GitHub actions but locally it works fine. I use node v18 so I regenerated changes to package-lock with node v16. Maybe there is some conflict of versions |
|
Could you resolve the conflict again? I'll merge afterwards |
|
I wanna cry 🥲 |
…_protocol_options
|
@bdbch Merged again |
|
@bdbch Hi! Can you take a look? |
bdbch
approved these changes
Feb 27, 2023
aliasliao
pushed a commit
to aliasliao/tiptap
that referenced
this pull request
May 24, 2023
* add optionalSlashSlash to protocol options * Update documentation * rename optionalSlashSlash to optionalSlashes * regenerate package-lock.json with node v16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
I need to link
tel:12312312. linkifyjs can findmailtoout of box but nottelhowever it can be done via custom protocol withoptionalSlashSlashenabledUpdated linkifyjs from
v3.0.5to4.1.0Some breaking changes (changelist)
mailto:now have typeurlinstead ofemailChanged
Linkextension