Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash dependencies in extension-floating-menu #3695

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

svenadlung
Copy link
Contributor

Removing lodash extension since they are not used within floating menu.

@svenadlung svenadlung requested a review from bdbch February 3, 2023 10:06
@svenadlung svenadlung self-assigned this Feb 3, 2023
@netlify
Copy link

netlify bot commented Feb 3, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 0235ab8
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/63e2182943c5b20008eefeea
😎 Deploy Preview https://deploy-preview-3695--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bdbch
bdbch previously approved these changes Feb 7, 2023
@bdbch bdbch merged commit ab7e6ca into main Feb 7, 2023
@bdbch bdbch deleted the refactoring/remove-lodash-dependencies branch February 7, 2023 09:22
aliasliao pushed a commit to aliasliao/tiptap that referenced this pull request May 24, 2023
* refactor(extension-floating-menu): remove lodash dependencies

* fix: typo

---------

Co-authored-by: Dominik <6538827+bdbch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants