fix(react): reset initialized when editorcontent is unmounting #3781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
svenadlung
previously approved these changes
Feb 26, 2023
jamesopti
previously approved these changes
Feb 27, 2023
|
I think this PR doesn't completely resolve this issue #3331 which is reproduced by #3533 Could you please consider an alternative approach that doesn't use |
|
I opened a PR about this. |
aliasliao
pushed a commit
to aliasliao/tiptap
that referenced
this pull request
May 24, 2023
…dosis#3781) * fix(react): reset initialized when editorcontent is unmounting * style: remove unneeded if statement
andrewlu0
pushed a commit
to trybaseplate/tiptap
that referenced
this pull request
Oct 20, 2023
…dosis#3781) * fix(react): reset initialized when editorcontent is unmounting * style: remove unneeded if statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should resolve the flushSync issues (see #3331, #3580, #3764) and pr #3533
From my local tests I didn't receive any error messages nor did my cursor stay in the old position after inserting a new React NodeView with an editor content.
closes #3331
closes #3580
closes #3764