feat(core): added new options for nodeInputRules for block replacements #4289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This PR adds two new options to the
nodeInputRule
function that help with nodeInput replacements. By default, nodeInputRules always try to replace into the current content which caused that extra<p>
in front of the new<hr>
because HR's can't be inserted into<p>
tags and Prosemirror doing it's Schema magic moved the hr below the paragraph.This change adds the following options:
blockReplace
Optional option which will replace the current node instead of inserting into it when set to true
addExtraNewline
Adds a new line with the schema's default node for the parent wrapper. (For example in doc that would be a paragraph).
How did you accomplish your changes
add those options to the nodeInputRule function.
How have you tested your changes
setHorizontalRule
functionHow can we verify your changes
Test in the deployed demo
Remarks
Nothing really - should not change behavior for inputRules not using those options
Checklist
Related issues
fixes #1964
fixes #3809
fixes #1665