React: Fix ReactNodeView renderer element updates not being applied #4321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdbch
approved these changes
Aug 11, 2023
svenadlung
approved these changes
Aug 14, 2023
svenadlung
approved these changes
Nov 22, 2023
bdbch
approved these changes
Nov 23, 2023
|
We're reverting this change for now. It seems like this change leads to all attributes to be added to the nodeview element including attributes that are used for the editor only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Currently, updates on attributes of
ReactNodeVieware not applied to its renderer element. It's noticeable when you are using elements that depends on its attributes to render correctly likecolspanin td elements. This PR tries to fix that issue.How did you accomplish your changes
Added a loop updating all the renderer element attributes on the update method of the class
ReactNodeView.How have you tested your changes
Tested locally.
How can we verify your changes
Add a NodeView to the table cell extension and try to merge them. More details on the linked issue.
Checklist
Related issues
Fixes #4239