fix(core): fix error when merging class attributes #4340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This PR fixes an issue that caused a crash in
mergeAttributes
when one of thevalue
ormergedAttributes
is not set.How did you accomplish your changes
I added checks to the mergeAttribute function that will throw back a fallback value of
[]
.How have you tested your changes
I tried adding a class in my local demo. I also added a test to check, if the option is set correctly afterwards.
How can we verify your changes
Run the local demo and configure the extension to have a class – it should work without any error throws & the test should run through.
Checklist