Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clicking formatted link #4426

Closed

Conversation

aldinezi
Copy link
Contributor

@aldinezi aldinezi commented Sep 7, 2023

Please describe your changes

How did you accomplish your changes

I have added a check using closest on event target.

How have you tested your changes

Tested locally

How can we verify your changes

You can verify this by changing openOnClick in link extension config, and then by clicking on a link within bold text.

Remarks

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

#4425

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit aca58b8
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/64f9d29e6983fb000812f74b
😎 Deploy Preview https://deploy-preview-4426--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@janthurau
Copy link
Collaborator

Thanks! I've recently merged another PR (#4423) that fixed the same issue, so closing this 🤓

@janthurau janthurau closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: clicking on a link that is a formatted text will not open the link
2 participants