Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small VRX 2023 changes #1095

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Small VRX 2023 changes #1095

merged 2 commits into from
Oct 10, 2023

Conversation

cbrxyz
Copy link
Member

@cbrxyz cbrxyz commented Oct 8, 2023

Description

Changes:

  • Heisenbug in mission runner: Mission tasks were not being tracked in a data structure, leaving them prone to deletion. Tasks are now added to a set. More info about this here: https://textual.textualize.io/blog/2023/02/11/the-heisenbug-lurking-in-your-async-code/
  • VRX classifier dying: Fixed the VRX classifier causing the mission to fail to spin up by moving it earlier in the file.
  • Ensuring VRX mission works with new axros: Last VRX changes were before the new version of txros, axros. The mission now works with this library.

@cbrxyz cbrxyz requested a review from andrew-aj October 8, 2023 02:49
Copy link
Contributor

@kawaiiPlat kawaiiPlat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does what it says on the tin

Copy link
Member

@andrew-aj andrew-aj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

                     _
                    | \
                     '.|
     _-   _-    _-  _-||    _-    _-  _-   _-    _-    _-
       _-    _-   - __||___    _-       _-    _-    _-
    _-   _-    _-  |   _   |       _-   _-    _-
      _-    _-    /_) (_) (_\        _-    _-       _-
              _.-'           `-._      ________       _-
        _..--`                   `-..'       .'
    _.-'  o/o                     o/o`-..__.'        ~  ~
 .-'      o|o                     o|o      `.._.  // ~  ~
 `-._     o|o                     o|o        |||<|||~  ~
     `-.__o\o                     o|o       .'-'  \\ ~  ~
          `-.______________________\_...-``'.       ~  ~
                                    `._______`.

SHIP IT

@cbrxyz cbrxyz merged commit a2ff9ec into master Oct 10, 2023
3 of 4 checks passed
@cbrxyz cbrxyz deleted the vrx-2023-fixes branch October 10, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants