Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General cleanup of surface.F90 needed #516

Closed
LarissaReames-NOAA opened this issue May 18, 2021 · 0 comments
Closed

General cleanup of surface.F90 needed #516

LarissaReames-NOAA opened this issue May 18, 2021 · 0 comments
Assignees

Comments

@LarissaReames-NOAA
Copy link
Collaborator

Similar to Issue #504 , the entire file surface.F90 could use some clean up. Outside of the interp subroutine, there's some old code in there that's no longer used, and an opportunity in nst_land_fill to move to using a loop over a FieldBundle to do most of the work of that subroutine. As this won't involve adding any functionalities that aren't already there, but mostly will be removing old code, I don't anticipate many tests being needed. A short test could probably be used to check that the newly-modified nst_land_fill is properly filling land points with the expected values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant