-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The latest version of chgres_cube does not support GEFS or any ensemble grib2 files as input #651
Comments
@ZhanZhang-NOAA do you have a sample GRIB2 dataset that causes the failure? |
@GeorgeGayno-NOAA Yes, here is one example on jet: |
@ZhanZhang-NOAA I was able to reproduce the error. The logic can't find any vertical levels -
Let me work on a fix. |
The GEFS data is identified in the ID section (section 1): https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_sect1.shtml octets 6-7 are '7' (NCEP) https://www.nco.ncep.noaa.gov/pmb/docs/on388/table0.html |
set the product template number accordingly. Fixes ufs-community#651.
Fixes ufs-community#651.
I think I have a fix. Test scripts/data on Mars - |
@ZhanZhang-NOAA Can you try my fix? Close my branch, then checkout my branch:
|
failures. Fixes ufs-community#651.
I was on AL for the last two weeks, I will test your fix soon and let you
know as soon as I get the results.
Many thanks!
…-Zhan
On Tue, May 24, 2022 at 4:27 PM GeorgeGayno-NOAA ***@***.***> wrote:
@ZhanZhang-NOAA <https://github.com/ZhanZhang-NOAA> Can you try my fix?
Close my branch, then checkout my branch:
git clone ***@***.***:GeorgeGayno-NOAA/UFS_UTILS.git
git checkout bugfix/chgres_gefs
—
Reply to this email directly, view it on GitHub
<#651 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE73MQWR2GMRIIT7MWTQLHDVLU3UPANCNFSM5WC2KBHQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@GeorgeGayno-NOAA I tested the bugfix version of chgres, it worked fine with GEFS input. |
Did you test the cold start files in the forecast model? |
Yes, I did. I ran the end-to-end HAFS system using GEFS as input for IC/BC,
the forecast job completed successfully.
…On Mon, Jun 13, 2022 at 9:19 AM GeorgeGayno-NOAA ***@***.***> wrote:
@GeorgeGayno-NOAA <https://github.com/GeorgeGayno-NOAA> I tested the
bugfix version of chgres, it worked fine with GEFS input.
Did you test the cold start files in the forecast model?
—
Reply to this email directly, view it on GitHub
<#651 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE73MQUZA4UXZYZYS4CYOS3VO4YN7ANCNFSM5WC2KBHQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
That's great! I would like to turn your test into a new regression test for GEFS data. Can I get your input GEFS file, the chgres configuration namelist, and the coldstart files? |
My test run files are on jet:
|
Fixes ufs-community#651.
machine will be turned off soon. Fixes ufs-community#651.
Fixes a bug that was introduced during the switch from the WGRIB2 to the G2 library. Add consistency test for GEFS data. Fixes #651.
@GeorgeGayno-NOAA The chgres_cube used to support reading in GEFS or any ensemble grib2 files, but the function is broken in the latest version. It doesn't support reading in GEFS or any ensemble grib2 files anymore. It looks like that the product definition template is hard-code to 0 in input_data,F90, which is only for deterministic forecast/analysis, while product definition template for ensemble product is 1, examples in input_data.F90:
jpdtn = 0 and
if (gfld%ipdtnum == 0) then
Is it possible to add an namelist parameter to switch reading deterministic and ensemble grib2 between jpdtn = 0 and 1 or through a better approach to recognize deterministic/ensemble automatically by the code? Also, it would be desirable to include a chgres_cube regression test for GEFS grib2 input.
The text was updated successfully, but these errors were encountered: