Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link_fixdirs.sh does not error when an invalid run environment is provided #700

Closed
WalterKolczynski-NOAA opened this issue Oct 4, 2022 · 2 comments · Fixed by #701
Closed

link_fixdirs.sh does not error when an invalid run environment is provided #700

WalterKolczynski-NOAA opened this issue Oct 4, 2022 · 2 comments · Fixed by #701
Assignees
@GeorgeGayno-NOAA
Labels
bug Something isn't working

Comments

@WalterKolczynski-NOAA
Copy link
Contributor

If an invalid $RUN_ENVIR is passed to link_fixdirs.sh, the script does not exit with a non-zero return code. It turns off the trace and prints an error message, but does not exit immediately.
@GeorgeGayno-NOAA
Copy link
Collaborator

@WalterKolczynski-NOAA Thanks for finding this bug.

Does the LINK need to be fixed as well?

[[ $RUN_ENVIR = nco ]] && LINK="cp -rp"

Didn't you add the -L option for one of the GFS tags?

@GeorgeGayno-NOAA GeorgeGayno-NOAA added the bug Something isn't working label Oct 4, 2022
@GeorgeGayno-NOAA GeorgeGayno-NOAA self-assigned this Oct 4, 2022
@WalterKolczynski-NOAA
Copy link
Contributor Author

Looks like we're just using cp -rp in our link script, at least in develop.

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Oct 4, 2022
@GeorgeGayno-NOAA
Fix bug in "link_fixdirs.sh". Add -L to the copy command.
c728b79 
Fixes ufs-community#700.
@GeorgeGayno-NOAA GeorgeGayno-NOAA mentioned this issue Oct 4, 2022
Merged
GeorgeGayno-NOAA added a commit that referenced this issue Oct 14, 2022
@GeorgeGayno-NOAA
Fix error handling in "link_fixdirs.sh". Add -L to the copy command. (#…
3c74c99 
…701)

Fixes #700.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeorgeGayno-NOAA GeorgeGayno-NOAA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug in "link_fixdirs.sh" GeorgeGayno-NOAA/UFS_UTILS
2 participants
@WalterKolczynski-NOAA @GeorgeGayno-NOAA