Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile warnings in chgres_cube #736

Closed
edwardhartnett opened this issue Dec 13, 2022 · 1 comment · Fixed by #747
Closed

compile warnings in chgres_cube #736

edwardhartnett opened this issue Dec 13, 2022 · 1 comment · Fixed by #747
Assignees
Labels
warning Warnings must be heeded...

Comments

@edwardhartnett
Copy link
Collaborator

@GeorgeGayno-NOAA seems like many of these would be trivially easy to fix:

/home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/program_setup.F90:307:2:

  307 |          if (trim(grib2_file_input_grid) == "NULL" .or. trim(grib2_file_input_grid) == "") then
      |         1
Warning: Nonconforming tab character at (1) [-Wtabs]
/home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/program_setup.F90:308:2:

  308 |                  call error_handler("FOR GRIB2 DATA, PLEASE PROVIDE GRIB2_FILE_INPUT_GRID", 1)
      |                1
Warning: Nonconforming tab character at (1) [-Wtabs]
/home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/program_setup.F90:309:2:

  309 |          endif
      |         1
Warning: Nonconforming tab character at (1) [-Wtabs]
/home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/program_setup.F90:317:2:

  317 |          if (.not. any((/character(4)::"GFS","NAM","RAP","HRRR"/)==trim(external_model))) then
      |         1
Warning: Nonconforming tab character at (1) [-Wtabs]
/home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/program_setup.F90:318:2:

  318 |                  call error_handler( "KNOWN SUPPORTED external_model INPUTS ARE GFS, NAM, RAP, AND HRRR. " // &
      |                1
Warning: Nonconforming tab character at (1) [-Wtabs]
/home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/program_setup.F90:324:2:

  324 |          endif
      |         1
Warning: Nonconforming tab character at (1) [-Wtabs]
/home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/program_setup.F90:333:2:

  333 |          if (trim(geogrid_file_input_grid) == "NULL" .or. trim(grib2_file_input_grid) == "") then
      |         1
Warning: Nonconforming tab character at (1) [-Wtabs]
/home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/program_setup.F90:334:2:

  334 |                  print*, "HRRR DATA DOES NOT CONTAIN SOIL TYPE INFORMATION. WITHOUT &
      |                1
Warning: Nonconforming tab character at (1) [-Wtabs]
/home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/program_setup.F90:336:4:

  336 |                         ACCURATE. "
      |                         1
Warning: Missing ‘&’ in continued character constant at (1) [-Wampersand]
/home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/program_setup.F90:337:2:

  337 |          endif
      |         1
Warning: Nonconforming tab character at (1) [-Wtabs]
/usr/local/bin/cmake -E touch sorc/grid_tools.fd/regional_esg_grid.fd/CMakeFiles/regional_esg_grid.dir/pmat5.f90.o.provides.build
/usr/local/bin/cmake -E cmake_copy_f90_mod sorc/grid_tools.fd/regional_esg_grid.fd/pesg.mod sorc/grid_tools.fd/regional_esg_grid.fd/CMakeFiles/regional_esg_grid.dir/pesg.mod.stamp GNU
/usr/local/bin/cmake -E touch sorc/grid_tools.fd/regional_esg_grid.fd/CMakeFiles/regional_esg_grid.dir/pesg.f90.o.provides.build
[ 22%] Building Fortran object sorc/grid_tools.fd/regional_esg_grid.fd/CMakeFiles/regional_esg_grid.dir/regional_esg_grid.f90.o
cd /home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/build/sorc/grid_tools.fd/regional_esg_grid.fd && /usr/bin/mpifort  -I/usr/include -g -fprofile-arcs -ftest-coverage -O0 -Wall -g -fbacktrace -fallow-argument-mismatch -fallow-invalid-boz -ggdb -c /home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/grid_tools.fd/regional_esg_grid.fd/regional_esg_grid.f90 -o CMakeFiles/regional_esg_grid.dir/regional_esg_grid.f90.o
[ 22%] Linking Fortran executable regional_esg_grid
cd /home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/build/sorc/grid_tools.fd/regional_esg_grid.fd && /usr/local/bin/cmake -E cmake_link_script CMakeFiles/regional_esg_grid.dir/link.txt --verbose=1
/usr/bin/mpifort -g -fprofile-arcs -ftest-coverage -O0 -Wall -g -fbacktrace -fallow-argument-mismatch -fallow-invalid-boz -ggdb CMakeFiles/regional_esg_grid.dir/pesg.f90.o CMakeFiles/regional_esg_grid.dir/pfun.f90.o CMakeFiles/regional_esg_grid.dir/pietc.f90.o CMakeFiles/regional_esg_grid.dir/pietc_s.f90.o CMakeFiles/regional_esg_grid.dir/pkind.f90.o CMakeFiles/regional_esg_grid.dir/pmat.f90.o CMakeFiles/regional_esg_grid.dir/pmat2.f90.o CMakeFiles/regional_esg_grid.dir/pmat4.f90.o CMakeFiles/regional_esg_grid.dir/pmat5.f90.o CMakeFiles/regional_esg_grid.dir/psym2.f90.o CMakeFiles/regional_esg_grid.dir/regional_esg_grid.f90.o -o regional_esg_grid  /usr/lib/x86_64-linux-gnu/libnetcdff.so -L/usr/lib/x86_64-linux-gnu -lnetcdff -Wl,-Bsymbolic-functions -flto=auto -ffat-lto-objects -flto=auto -Wl,-z,relro -Wl,-z,now -lnetcdf -lnetcdf -lm /usr/lib/x86_64-linux-gnu/libnetcdf.so -L/usr/lib/x86_64-linux-gnu -L/usr/lib/x86_64-linux-gnu/hdf5/serial -lnetcdf 
/home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/program_setup.F90:475:59:

  475 |     if(present(this_miss_var_value)) this_miss_var_value = missing_var_values(i)
      |                                                           1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
/home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/program_setup.F90: In function ‘__program_setup_MOD_read_setup_namelist’:
/home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/program_setup.F90:198:30: warning: ‘.filename_to_use’ may be used uninitialized [-Wmaybe-uninitialized]
  198 |     filename_to_use = filename
      |                              ^
[ 22%] Building Fortran object sorc/chgres_cube.fd/CMakeFiles/chgres_cube_lib.dir/search_util.F90.o
cd /home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/build/sorc/chgres_cube.fd && /usr/bin/mpifort  -I/home/runner/g2/include_d -I/usr/include -I/home/runner/nemsio/include -I/home/runner/sfcio/include -I/home/runner/sigio/include -I/home/runner/bacio/include_4 -I/home/runner/ip/include_d -I/home/runner/sp/include_d -I/home/runner/w3nco/include_d -I/home/runner/esmf/mod -I/home/runner/esmf/include -g -fprofile-arcs -ftest-coverage -O0 -Wall -g -fbacktrace -fallow-argument-mismatch -fallow-invalid-boz -ffree-line-length-0 -fdefault-real-8 -fallow-argument-mismatch -ggdb -Jmod -c /home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/search_util.F90 -o CMakeFiles/chgres_cube_lib.dir/search_util.F90.o
/home/runner/work/UFS_UTILS/UFS_UTILS/ufs_utils/sorc/chgres_cube.fd/search_util.F90:46:49:

   46 |  subroutine search (field, mask, idim, jdim, tile, field_num, latitude, terrain_land, soilt_climo)
      |                                                 1
Warning: Unused dummy argument ‘tile’ at (1) [-Wunused-dummy-argument]
@edwardhartnett edwardhartnett added the warning Warnings must be heeded... label Dec 13, 2022
@GeorgeGayno-NOAA GeorgeGayno-NOAA self-assigned this Dec 13, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 13, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 14, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 14, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 14, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 14, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 14, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 14, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 15, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 15, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 15, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 15, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 15, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 16, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 16, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 16, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 16, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 16, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 16, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 16, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 16, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 16, 2022
@GeorgeGayno-NOAA
Copy link
Collaborator

The branch at 4a67a13 was compiled with no warnings on Hera using the GNU compiler and these options: set(CMAKE_Fortran_FLAGS_DEBUG "-ggdb -Wall")

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 16, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 19, 2022
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
warning Warnings must be heeded...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants