Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on module_nwp_base.f90 #790

Merged
merged 1 commit into from
Mar 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sorc/fvcom_tools.fd/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
set(fortran_src
kinds.f90
module_ncio.f90
module_nwp_base.f90
module_nwp.f90)
# process_FVCOM.f90)

set(exe_src process_FVCOM.f90)

Expand Down
30 changes: 1 addition & 29 deletions sorc/fvcom_tools.fd/module_nwp.f90
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,15 @@
module module_nwp

use kinds, only: r_kind, r_single, i_short, rmissing
use module_nwp_base, only: nwpbase
! use module_map_utils, only: map_util
use module_ncio, only: ncio

implicit none

public :: fcst_nwp
public :: nwp_type

private
type :: nwp_type
type :: fcst_nwp
character(len=6) :: datatype !< Data type.
integer :: numvar !< Number of variabls.
integer :: xlat !< Number of latitudes.
Expand Down Expand Up @@ -66,15 +64,6 @@ module module_nwp
real(r_kind), allocatable :: nwp_zorl_w(:,:) !< warm start surface roughness
real(r_kind), allocatable :: nwp_hice_w(:,:) !< warm start ice thickness

end type nwp_type

type, extends(nwp_type) :: fcst_nwp
! The pointers are carryover from when I inherited the code from
! GSL's work with HRRR for a similar use. I am not sure with
! object based coding in Fortran if it needs to have parts
! initialized to gain access to the procedures within it. - D. Wright.
type(nwpbase), pointer :: head => NULL() !< Pointer to head of list.
type(nwpbase), pointer :: tail => NULL() !< Pointer to tail of list.
contains
procedure :: initial => initial_nwp !< Defines vars and names. @return
procedure :: list_initial => list_initial_nwp !< List the setup. @return
Expand Down Expand Up @@ -212,9 +201,6 @@ subroutine initial_nwp(this,itype,wcstart)
stop 1234
end if

this%head => NULL()
this%tail => NULL()

write(6,*) 'Finished initial_nwp'
write(6,*) ' '

Expand Down Expand Up @@ -442,8 +428,6 @@ subroutine finish_nwp(this,itype,wcstart)
character(len=6), intent(in) :: itype
character(len=4), intent(in) :: wcstart

type(nwpbase), pointer :: thisobs,thisobsnext

deallocate(this%varnames)
deallocate(this%latname)
deallocate(this%lonname)
Expand Down Expand Up @@ -472,18 +456,6 @@ subroutine finish_nwp(this,itype,wcstart)
write(6,*) 'no deallocation'
end if

thisobs => this%head
if(.NOT.associated(thisobs)) then
write(6,*) 'No memory to release'
return
endif
do while(associated(thisobs))

thisobsnext => thisobs%next
call thisobs%destroy()
thisobs => thisobsnext
enddo

write(6,*) 'Finished finish_nwp'
write(6,*) ' '

Expand Down
135 changes: 0 additions & 135 deletions sorc/fvcom_tools.fd/module_nwp_base.f90

This file was deleted.

4 changes: 1 addition & 3 deletions tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ function(PULL_DATA THE_URL THE_FILE)
endif()
endfunction()

# Add the test subdirecotries.
# fvcom test only works for Intel. Comment out for now.
#add_subdirectory(fvcom_tools)
add_subdirectory(fvcom_tools)
add_subdirectory(filter_topo)
add_subdirectory(chgres_cube)
add_subdirectory(fre-nctools)
Expand Down