Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global_cycle - Add soil moisture nudging for NoahMP option #809

Merged
merged 19 commits into from
Apr 18, 2023
Merged

global_cycle - Add soil moisture nudging for NoahMP option #809

merged 19 commits into from
Apr 18, 2023

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Apr 12, 2023 •
edited
Loading

DESCRIPTION OF CHANGES:

When using NoahMP, output adjusted soil moisture to the restart files.

TESTS CONDUCTED:

Tested on a canned C96 case. See below for details.

The (Noah-based) regression tests were run on Hera and passed.

DEPENDENCIES:

None.

DOCUMENTATION:

N/A

ISSUE:

Fixes #761.

@GeorgeGayno-NOAA
Add new write routine that updates records from an
468ecee 
existing file instead of writing an entire new file.

Modify driver script to make copy of the input restart
files for updating.

Fixes ufs-community#761.
@GeorgeGayno-NOAA
Merge branch 'develop' into feature/cycle_noahmp
7df8ccc 
Fixes ufs-community#761.
@GeorgeGayno-NOAA
Determine whether to process noah or noah-mp based on
228cb2b 
the records in the input file.

Fixes ufs-community#761.
@GeorgeGayno-NOAA
Merge branch 'develop' into feature/cycle_noahmp
2e88092 
Fixes ufs-community#761.
@GeorgeGayno-NOAA
Merge branch 'develop' into feature/cycle_noahmp
582021b 
Fixes ufs-community#761.
@GeorgeGayno-NOAA
Begin writing a new output routine that updates an
00e0127 
existing restart file. The goal is to have one routine
that works for noah and noah-mp.

Fixes ufs-community#761
@GeorgeGayno-NOAA
Merge branch 'develop' into feature/cycle_noahmp
e2c468a 
Fixes ufs-community#761.
@GeorgeGayno-NOAA
Add remaining variable to new write routine.
c98feac 
Fixes ufs-community#761.
@GeorgeGayno-NOAA
Point to new write routine for noah-mp.
0fb89c3 
Fixes ufs-community#761.
@GeorgeGayno-NOAA
Merge branch 'develop' into feature/cycle_noahmp
44c3f4b 
Fixes ufs-community#761.
@GeorgeGayno-NOAA
Remove old test write routine.
1063f9b 
Fixes ufs-community#761.
@GeorgeGayno-NOAA
Merge branch 'develop' into feature/cycle_noahmp
85d64d9 
Fixes ufs-community#791
@GeorgeGayno-NOAA
Remove old write routine.
6f62ceb 
Fixes ufs-community#791.
@GeorgeGayno-NOAA
Rename write routine.
4e724bb 
Fixes ufs-community#791.
@GeorgeGayno-NOAA
Merge branch 'develop' into feature/cycle_noahmp
0df4d60
@GeorgeGayno-NOAA
Update soil moisture for NoahMP.
d2f7e1b 
Fixes ufs-community#761.
@GeorgeGayno-NOAA
Merge branch 'develop' into feature/cycle_noahmp
d830600 
Fixes ufs-community#761.
@GeorgeGayno-NOAA
Merge branch 'develop' into feature/cycle_noahmp
c4f0690 
Fixes ufs-community#761.
@GeorgeGayno-NOAA GeorgeGayno-NOAA self-assigned this Apr 12, 2023
@GeorgeGayno-NOAA
Copy link
Collaborator Author

GeorgeGayno-NOAA commented Apr 12, 2023 •
edited
Loading

Tested using a canned C96 test case on Hera: /scratch1/NCEPDEV/da/George.Gayno/ufs_utils.git/global_cycle_noahmp

Attached is a plot of the total soil moisture differences between the input and output files (tile 1). The differences are of the magnitude expected for a 60-day relaxation to climatology.

Screenshot (36)

@GeorgeGayno-NOAA
Copy link
Collaborator Author

GeorgeGayno-NOAA commented Apr 12, 2023 •
edited
Loading

Same as the previous plot of total soil moisture, but for liquid soil moisture:

Screenshot (38)

Note the larger differences along the coastline. These are due to the input data file having non-zero moisture values at water points. The nudging is removing these spurious points.

Plot of land mask

Screenshot (40)

Plot of input liquid soil moisture. Note the non-zero moisture values over water.

Screenshot (42)

@GeorgeGayno-NOAA
Copy link
Collaborator Author

@HelinWei-NOAA can you review?

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review April 12, 2023 18:47
@HelinWei-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA Is the soil moisture increment due to the nudging calculated in sfcsub.f?

@GeorgeGayno-NOAA
Copy link
Collaborator Author

@GeorgeGayno-NOAA Is the soil moisture increment due to the nudging calculated in sfcsub.f?

Yes.

@GeorgeGayno-NOAA
Copy link
Collaborator Author

@HelinWei-NOAA are there any additional updates required for NoahMP? If not, I can close #761.

Fractional grids will be worked under #549.

@HelinWei-NOAA
Copy link
Collaborator

@HelinWei-NOAA are there any additional updates required for NoahMP? If not, I can close #761.

No at this moment.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 5b03845 into ufs-community:develop Apr 18, 2023
@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the feature/cycle_noahmp branch April 18, 2023 12:22
AnnetteGibbs-NOAA added a commit to AnnetteGibbs-NOAA/UFS_UTILS that referenced this pull request Jul 3, 2023
@AnnetteGibbs-NOAA
Merge remote-tracking branch 'origin/develop' into feature/dyn_dng
2286a16 
* origin/develop:
  Update ccpp submodule (ufs-community#827)
  Change length of character variable "mosaic_name" in "make_solo_mosaic.c" (ufs-community#824)
  Update GDAS INIT utility for GFS COM reorganization (ufs-community#820)
  Add backup calculation for orography and mask generation (ufs-community#713)
  Improve repository build script (ufs-community#819)
  Use latest wgrib2 executable on Jet. (ufs-community#816)
  chgres_cube - Minor update for high-resolution grids . (ufs-community#814)
  Update PR template (ufs-community#813)
  global_cycle - Add soil moisture nudging for NoahMP option (ufs-community#809)
  Release v1.10.0 (ufs-community#807)
  Run sfc_climo_gen utility on Hera (ufs-community#791)
  Fix bug in chgres_cube subroutine search_many (ufs-community#808)
  sfc_climo_gen - Output fractions of each vegetation/soil type category (ufs-community#748)
  Replace w3nco library with w3emc (ufs-community#802)
  Fix Debug compilation (ufs-community#800)
  Update WCOSS2 build module to use new ESMF v8.4.1 library. (ufs-community#799)
  Update chgres_cube documentation for duplicate grib2 records (ufs-community#795)
  Use latest Cray modules on WCOSS2 (ufs-community#792)
  Remove checksum attribute from global_cycle restart files (ufs-community#794)
  Remove goto statements from chgres_cube (ufs-community#775)
  FVCOM_TOOLS - Remove dependency on module_nwp_base.f90 (ufs-community#790)
  Remove "gcovr" step from the 'developer' workflow (ufs-community#785)
  Update build module for Cheyenne (ufs-community#783)
  GDAS Init utility - consolidate the copy of coldstart files (ufs-community#773)
  Remove support for ODIN machine (ufs-community#782)
  Update GDAS INIT utility to optionally use fracoro data (ufs-community#741)
  Option to build only application specific utilities (e.g. GFS) (ufs-community#777)
  Use combined IP/IP2 library (ufs-community#695)
  Initial updates to global_cycle for Noah-MP land model (ufs-community#774)
  New resolution options for the cpld_gridgen utility (ufs-community#769)
  Use new EPIC-maintained hpc-stack on Jet  (ufs-community#771)
  Update GDAS initialization scripts for the new ENKF directory (ufs-community#764)
  Reduce memory usage in chgres_cube (ufs-community#766)
  Detect duplicate vertical levels in chgres_cube. (ufs-community#767)
  Point to new input orography directory. (ufs-community#758)
  Release version 1.9 (ufs-community#754)
  HAFSv1 grid nesting updates (ufs-community#752)
  Remove compiler warnings from chgres_cube (ufs-community#747)
  chgres_cube: Split input_data module into to 3 separate modules (ufs-community#744)
  More work on CI, checking with different versions of ESMF (ufs-community#742)
  Add processing of soil color to sfc_climo_gen (ufs-community#721)
  more work on CI - added Linux_versions workflow (ufs-community#739)
  Add TEST_FILE_DIR option to CMake build, where test data files can be found instead of using FTP.  (ufs-community#732)
  adding developer workflow (ufs-community#724)
  Update GDAS INIT utility for v16.3. (ufs-community#723)
  OROG_GSL - Remove negative bias in orographic asymmetery (OA) fields (ufs-community#718)
  Incorporate BNU soil type data (ufs-community#717)
  High-resolution MODIS and STATSGO veg/soil data. (ufs-community#703)
  Run WCOSS2 consistency tests under role account (ufs-community#711)
  Fix macOS CI workflow (ufs-community#715)
  Add utility codes to create BNU soil texture data (ufs-community#707)
  Update chgres_cube to output netcdf4 file. (ufs-community#704)
  Incorporate high-res global VIIRS vegetation data. (ufs-community#699)
  Run grid_gen consistency tests in parallel. (ufs-community#697)
  Fix error handling in "link_fixdirs.sh". Add -L to the copy command. (ufs-community#701)
  Update for new fixed data directory structure (ufs-community#688)
  Add WCOSS2 support for tests (ufs-community#693)
  Increase test data pull timeout (ufs-community#692)
  Option to install binaries to any directory. (ufs-community#685)
  Update global_cycle to use the latest CCPP version of sfcsub.F (ufs-community#671)
  Incorporate weight_gen program. (ufs-community#677)
  Add install of jpeg-turbo to macos workflows (ufs-community#684)
  Improve logic in regression test driver script (ufs-community#681)
  Release v1.8 (ufs-community#679)
  Update link_fixdirs.sh for new data directories (ufs-community#672)
  Update default ice climatology in ./ush/global_cycle.sh. (ufs-community#664)
  Remove all references to WCOSS 1 from UFS_UTILS (ufs-community#667)
  Update workflows to use latest macOS and ubuntu (ufs-community#675)
  Update GDAS Initialization utility for recent HPSS tarball name change (ufs-community#666)
  Port UFS_UTILS to WCOSS2 (ufs-community#642)
  Fix chgres_cube to process GEFS GRIB2 data (ufs-community#658)
  Update global_cycle_driver.sh for GFS OPS directory convention  (ufs-community#655)
  Update documentation for SRW App (ufs-community#656)
  New coupled model utility (ufs-community#647)
  Update support for S4 and enable regression testing (ufs-community#654)
  global_cycle - Link to CCPP version of sfcsub.F (ufs-community#636)
  Add processing of new global AFWA snow data to emcsfc_snow2mdl. (ufs-community#648)
  Update build module on Cheyenne (ufs-community#646)
  Move to Intel 2022 on Jet, Hera and Orion (ufs-community#650)
  Host doxygen documentation for multiple releases (ufs-community#644)
  Download unit test data as part of the CMake build (ufs-community#630)
  chgres_cube - Complete removal of wgrib2 library (ufs-community#641)
  Eliminate circular dependency in chgres_cube
  Update workflow files to pull netcdf-c library from GitHub
  chgres_cube - Remove the wgrib2 library from the GRIB2 data read routines.
  Undefined symbols on macOS with Intel compiler (ufs-community#628)
  Update FVCOM code to handle sub-domain restart files using multiple cores. (ufs-community#624)
  chgres_cube - Run routine 'convert_omega' on all tasks. (ufs-community#627)
  Use ESMF 8.2.0 library
  Automate update of consistency test baseline data. (ufs-community#603)
  Update workflow files to use newer versions of ESMF and NCEPLIBS. (ufs-community#617)
  Update build modules to be lua compliant (ufs-community#614)
  Allow FVCOM tools to Update Ice Surface Roughness Length (ufs-community#604)
  Update the requested memory in the Orion chgres_cube consistency test script (ufs-community#611)
  Use copy of grib_util under Jet role account. (ufs-community#608)
  Run consistency tests on Orion using role account (ufs-community#606)
  Run consistency tests on Hera using role account (ufs-community#605)
  Run consistency tests on Jet using role account. (ufs-community#607)
  Update more documentation after move to ufs-community (ufs-community#597)
  fvcom_tools - Add option to process 'cold' or 'warm' restart files (ufs-community#595)
  Update documentation after move to ufs-community (ufs-community#594)
  chgres_cube - Eliminate segmentation fault in input_data.F90 (ufs-community#585)
  Update to language of unit test README to match that in unit test.
  chgres_cube - Simplify surface processing using field bundles (ufs-community#572)
  Add compiler flags for GNU Fortran v10 or newer compilers. (ufs-community#583)
  Move verbose output from example unit test to be commented to streamline test output.
  Updates to test README to add instructions for use of example unit test.
  Add Findwgrib2.cmake (ufs-community#578)
  Added unit test to be used as an instructional example for new users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBeck-NOAA JeffBeck-NOAA JeffBeck-NOAA approved these changes

@HelinWei-NOAA HelinWei-NOAA HelinWei-NOAA approved these changes

@LarissaReames-NOAA LarissaReames-NOAA Awaiting requested review from LarissaReames-NOAA

Assignees

@GeorgeGayno-NOAA GeorgeGayno-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update global_cycle for Noah-MP cycling
3 participants
@GeorgeGayno-NOAA @HelinWei-NOAA @JeffBeck-NOAA