Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single step oro & fix files generation procedure for atm and ocn res combo #830
Single step oro & fix files generation procedure for atm and ocn res combo #830
Changes from 8 commits
f9e63a3
26eeef1
ecf2442
478fbde
b91b5eb
6a004a7
9d1be51
d386999
e34c7d0
2653ab2
34a8676
cbb553f
6a7b778
0b9a03e
d6221b3
4a208a1
069d1bf
41f87d6
ab1e628
24c93fa
eb0a511
65d34fa
b74ebc8
4455d90
e700e0a
f4769f8
400cc13
084d51c
c246ffc
e0d86d3
2c9b502
98caf8b
6179b24
fc17593
22dadfe
6f3fe9e
64fdfd7
6e1c9b4
df89e12
d4cfcc0
1105547
05659d9
6b30462
4b3b25f
156bd27
8284cbe
0f60b72
36d6ec4
5dc234d
ce8b596
276f846
4769aea
df2420b
b24724f
28f6ef4
df0788d
54b5564
d0e2978
eadcd71
e2fbc56
13145aa
e1c28f8
49b131d
a0bfb00
1c53ea1
6e18c0f
76dd01a
2941924
eb31490
7e64969
451d13c
5563ce4
29774b1
10a3524
9977d8b
3151f77
28a4cdb
ccc72e3
291ba43
07fdec3
c11ddcf
cefff38
58da591
5dcb766
2b362b5
30e2834
a2082c0
2f2cb70
27532c9
d5c01f6
9d60740
d0d1e8f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am getting a warning here. Routine handle_err only takes one argument. The character sting should be removed from the argument list. That string could be printed before the call to handle_err.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed that and added a print statement to o/p the error message inside the if statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon closer inspection, routine handle_err is for netcdf errors. In this case, the minus 1 return code will be converted to a netcdf error message, which will be misleading to the user. Maybe, you should not call that routine and do something like this instead:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the insightful tip. Noted. I will make suggested change and test it. I will also clean up that code in the next commit