Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "-fallow-argument-mismatch compile" flag from chgres_cube build #865

Merged
merged 13 commits into from
Oct 27, 2023
Merged

Remove "-fallow-argument-mismatch compile" flag from chgres_cube build #865

merged 13 commits into from
Oct 27, 2023

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Oct 25, 2023 •
edited
Loading

DESCRIPTION OF CHANGES:

The "-fallow-argument-mismatch" compiler flag is needed when building chgres_cube using GNU v10. Make minor adjustments to the source code to eliminate the need for this flag. Also, remove this flag from build of other programs that don't require it.

TESTS CONDUCTED:

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera and WCOSS2). Done using b00c745.
  • Compile branch on Hera using GNU. Done on Hera using b00c745.
  • Compile branch in 'Debug' mode on WCOSS2. Done on Dogwood using b00c745.
  • Run unit tests locally on any Tier 1 machine. Done on Hera using b00c745.
  • Run relevant consistency tests locally on all Tier 1 machines. Done using b00c745. All tests passed.

Note: All consistency tests use Intel. Since only the chgres_cube source code changed, only those consistency tests were run.

DEPENDENCIES:

None.

DOCUMENTATION:

N/A

ISSUE:

Fixes #471

CONTRIBUTORS:

@kgerheiser

@GeorgeGayno-NOAA
Update workflow to run gnu 10.
9dea217
@GeorgeGayno-NOAA
Remove the fallow-argument-mismatch compile flag from
27d8469 
some CMakeLists.txt files. Replace 'use mpi' with 'use mpi_f08'
in chgres_cube.

Fixes ufs-community#471.
@GeorgeGayno-NOAA
Merge branch 'develop' into bugfix/gcc_mpi
74d2a8c 
Fixes ufs-community#471
@GeorgeGayno-NOAA
Merge branch 'develop' into bugfix/gcc_mpi
4cce02d 
Fixes ufs-community#471
@GeorgeGayno-NOAA
As a test, add back flag for glbevents.
172a7ce 
Fixes ufs-community#471.
@GeorgeGayno-NOAA
Fix typo.
a49aa8a 
Fixes ufs-community#471.
@GeorgeGayno-NOAA
Add back flag for global_cycle.
67550c9 
Fixes ufs-community#471.
@GeorgeGayno-NOAA
Update mpi use statement for chgres_cube.
98371f4 
Fixes ufs-community#471.
@GeorgeGayno-NOAA
Turn off for coupled gridgen code.
4fb7ee6 
Fixes ufs-community#471.
@GeorgeGayno-NOAA
Turn off flags for noah.fd.
8918602 
Fixes ufs-community#471.
@GeorgeGayno-NOAA
Turn off flag for weight_gen.
8618de7 
Fixes ufs-community#471.
@GeorgeGayno-NOAA
Copy link
Collaborator Author

The glbevents and global_cycle still require this flag. These can be worked under another issue. Fixing global_cycle is more involved because the problem is in the sfcsub.F routine, which is part of the CCPP physics repository.

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review October 26, 2023 15:59
@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 325c32f into ufs-community:develop Oct 27, 2023
4 checks passed
@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the bugfix/gcc_mpi branch October 27, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardhartnett edwardhartnett edwardhartnett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chgres_cube should build without -fallow-argument-mismatch compile flag
2 participants
@GeorgeGayno-NOAA @edwardhartnett