Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the gsi land increment file name to append the rank. #887

Conversation

ClaraDraper-NOAA
Copy link
Contributor

@ClaraDraper-NOAA ClaraDraper-NOAA commented Jan 18, 2024

DESCRIPTION OF CHANGES:

Global_workflow now calls global_cycle using NPES=number of ensemble members When applying the (global, Gaussian) land increments, each task then now needs to read that ensemble member's increment file.

Previously global_cycle was called with NPES=number tiles=6, so each task read the same increment file.

To address this I've appended the rank to the land increment filename before opening it (as is done for the other input files).

TESTS CONDUCTED:

Compiled on hera. For the reg_tests to pass, will need to create links to the new file names, e.g.:
in:

/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/reg_tests/global_cycle/input_data_noahmp/

ln -s sfcincr_gsi sfcincr_gsi.001
ln -s sfcincr_gsi sfcincr_gsi.002
ln -s sfcincr_gsi sfcincr_gsi.003
ln -s sfcincr_gsi sfcincr_gsi.004
ln -s sfcincr_gsi sfcincr_gsi.005
ln -s sfcincr_gsi sfcincr_gsi.006

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2). Done using ab9b0b9.
  • Compile branch on Hera using GNU. Done using ab9b0b9.
  • Compile branch in 'Debug' mode on WCOSS2. Done on Cactus using ab9b0b9.
  • Run unit tests locally on any Tier 1 machine. Done on Cactus using ab9b0b9.
  • Run relevant consistency tests locally on all Tier 1 machine. Done using ab9b0b9.

Describe any additional tests performed.

  • Doxygen was created without warnings.

DEPENDENCIES:

None.

DOCUMENTATION:

N/A.

ISSUE:

This PR is required to address global_workflow issue:
NOAA-EMC/global-workflow#1479

(I'll submit the PR for this issue in the next few days).

CONTRIBUTORS (optional):

N/A

Necessary, as global_workflow now calls global_cycle using NPES=number of ensemble members
Each task needs to read that ensemble member's increment file.
(previously global_cycle was called with NPES=number tiles=6, so each task read the same incement file.
@GeorgeGayno-NOAA
Copy link
Collaborator

I made the required links for the sfcincr_gsi file on Hera. All tests passed.

@ClaraDraper-NOAA
Copy link
Contributor Author

Great, thanks George.

@GeorgeGayno-NOAA
Copy link
Collaborator

Looks good. Will merge today.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 93b4884 into ufs-community:develop Jan 19, 2024
4 checks passed
@ClaraDraper-NOAA ClaraDraper-NOAA deleted the bugfix/upd_landfilename branch August 7, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants