Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ip v5 support #910

Merged

Conversation

AlexanderRichert-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Mar 7, 2024

DESCRIPTION OF CHANGES:

This PR adds support for ip v5 (which subsumes sp library), while leaving support for older ip+sp combo.

TESTS CONDUCTED:

The following were all completed using ip v5 (no separate sp library), with the exception of the test on Hera described below the checklist.

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2).
  • orion: /home/arichert/spack-stack-ufsutils-ip5/UFS_UTILS/build
  • hera: /scratch1/NCEPDEV/nems/Alexander.Richert/spack-stack-ufsutils-ip5/envs/test/UFS_UTILS/build
  • hercules: /work/noaa/nems/arichert/spack-stack-ufsutils-ip5/UFS_UTILS/build
  • jet: /home/Alexander.Richert/spack-stack-ufsutils-ip5/UFS_UTILS/build (ran MPI tests manually; all passed)
  • acorn: /lfs/h1/emc/nceplibs/noscrub/alexander.richert/spack-stack-ufsutils-ip5/UFS_UTILS/build
  • Compile branch on Hera using GNU. /scratch1/NCEPDEV/nems/Alexander.Richert/spack-stack-ufsutils-ip5/envs/test/UFS_UTILS/build_gcc
  • Compile branch in 'Debug' mode on WCOSS2. /lfs/h1/emc/nceplibs/noscrub/alexander.richert/spack-stack-ufsutils-ip5/UFS_UTILS/build_debug
  • Run unit tests locally on any Tier 1 machine.
  • Run relevant consistency tests locally on all Tier 1 machine. Done using c8cb906. All tests passed as expected.

Also successfully compiled & ran ctest suite on Hera with ip 4 (+sp) to ensure all the logic still supports the existing ip+sp combo: /scratch1/NCEPDEV/nems/Alexander.Richert/spack-stack-ufsutils-ip5/envs/test/UFS_UTILS/build_ip4

DEPENDENCIES:

none

DOCUMENTATION:

n/a

ISSUE:

Related to JCSDA/spack-stack#1020

@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as ready for review March 8, 2024 07:53
@AlexanderRichert-NOAA
Copy link
Collaborator Author

@GeorgeGayno-NOAA could we do a release with these changes as soon as possible? I'd really like to get ip v5 into the next spack-stack release and this is the last piece of the puzzle.

@GeorgeGayno-NOAA GeorgeGayno-NOAA self-requested a review March 8, 2024 17:55
@GeorgeGayno-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA - the consistency tests are located under ./reg_tests. For this PR, the chgres_cube, global_cycle, grid_gen, snow2mdl and weight_gen tests will need to be run. Can you run them on Hera? You are not changing the version of IP in this PR, so I would not expect differences.

@GeorgeGayno-NOAA
Copy link
Collaborator

GeorgeGayno-NOAA commented Mar 8, 2024

@AlexanderRichert-NOAA - the consistency tests are located under ./reg_tests. For this PR, the chgres_cube, global_cycle, grid_gen, snow2mdl and weight_gen tests will need to be run. Can you run them on Hera? You are not changing the version of IP in this PR, so I would not expect differences.

I ran these tests on Hera/Orion/Cactus/Hercules using c8cb906. They all passed as expected. I will do Jet next.

@GeorgeGayno-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA - the consistency tests are located under ./reg_tests. For this PR, the chgres_cube, global_cycle, grid_gen, snow2mdl and weight_gen tests will need to be run. Can you run them on Hera? You are not changing the version of IP in this PR, so I would not expect differences.

I ran these tests on Hera/Orion/Cactus/Hercules using c8cb906. They all passed as expected. I will do Jet next.

They also passed on Jet.

@GeorgeGayno-NOAA GeorgeGayno-NOAA added the enhancement New feature or request label Mar 11, 2024
@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 5e39d0a into ufs-community:develop Mar 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants