fix NSSL MP init issue when initialized from other microphysics schemes #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiliDong-NOAA
requested review from
grantfirl,
Qingfu-Liu,
dustinswales and
mzhangw
as code owners
Qingfu-Liu
approved these changes
Jan 23, 2024
grantfirl
approved these changes
Jan 24, 2024
|
EPIC wishes to go to the UFSWM PR this is attached to Today/Tomorrow. Since there have been changes since the last review, could we get another review to make sure the recent commits are OK? |
|
Forgot to mention, make sure you're ready to sync up to auth repo once the current UFSWM PR is merged later today. |
grantfirl
approved these changes
Jan 29, 2024
|
@grantfirl testing is complete on UFS-WM PR #2098 . Could you please merge this PR for us? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix from Ted Mansell @MicroTed on NSSL MP initialization to check if there is missing number of concentration for any non-zero hydrometers mixing ratio. NSSL MP will calculate N from mixing ratio in the first timestep if missing value is found. This fix will guarantee that NSSL MP enters the correct warm/cold start initializations.