Skip using fluxes provided by land component for first time step #234
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uturuncoglu
requested review from
grantfirl,
rhaesung,
Qingfu-Liu,
dustinswales,
barlage and
cenlinhe
as code owners
|
JFYI, The top level UFS WM PR is still in draft mode. I am still working on it. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the dependency between atmosphere and land components, the atmosphere model gets all zero from land component model in the initial coupling time step. This PR aims to fix this issue and skips data coming from land component (all zero) at first coupling time step and use the land fluxes calculated by noahmp land model found in ccpp/physics. After first coupling time step, the coupled configuration (cpld_control_p8_lnd) will continue to use fluxes coming from component model.