using NoahMP tiled tq2m with the bug fix #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HelinWei-NOAA
requested review from
grantfirl and
ChunxiZhang-NOAA
as code owners
grantfirl
approved these changes
Nov 30, 2022
This was referenced Dec 1, 2022
barlage
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
All the changes look good. There was some minor discussion on the fork internal PR (HelinWei-NOAA#53) but those have been addressed.
ChunxiZhang-NOAA
approved these changes
Dec 1, 2022
|
ALl tests are done on ufs-wm pr 1511 side. Please, go ahead to merge in this pr. |
|
@jkbk2004 Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2mq over the bared soil has been improved significantly by using NoahMP internal diagnosed tiled values after the bug fixed. So we would like to get this into HR1.
UFS_P8_HR1_TQ2m_16Day_25Nov022_Zheng.pptx