-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize ozone physics into CCPP phases #75
Reorganize ozone physics into CCPP phases #75
Conversation
…ade radiation_aerosols.f ccpp compliant
…Provided as ccpp interstitials.
… Provided as ccpp interstitials.
…Provided as ccpp interstitials.
…vided as ccpp interstitials.
… as ccpp interstitials.
Update CODEOWNERS
@grantfirl @Qingfu-Liu @mkavulich |
Could you update these PRs and change the superrepo PRs from draft to PR? Also, have you run RTs on Hera or would you like me to? |
@grantfirl I've run the RTs on Hera. All tests past except one, in which one field disagrees. The total photochemical tendency (h2o+o3) differs, but all the individual o3 photochemical tendencies agree, and there's no change to the h2o scheme, so something is not getting accumulated correctly. I will look into this more later today. |
@grantfirl RTs on Hera Intel pass and everything is up-to-date. |
@grantfirl @mkavulich @Qingfu-Liu All tests are done at ufs-community/ufs-weather-model#1851. Please, go ahead to merge this pr. |
@jkbk2004 Merged |
I just came across this and wanted to note that the use if |
sync with ufs/dev
This PR contains a major reorganization of the NRL (2015) ozone physics parameterization. The major changes include:
Updated on 09/28/2023
With these changes, the ozone physics is"stateless" in memory, host-model agnostic, and self-contained within a single module.
Going forward, h2o photolysis, aerosol climatology, and the CCN/IN data schemes are nearly identical, and could be refactored in the same way.