Add option to write 3d soilt, soilw and soill variables to a history file

[DusanJovic-NOAA]

Commit Queue Requirements:

• Fill out all sections of this template.

• All sub component pull requests have been reviewed by their code managers.

• Run the full RT suite (compared to current baselines) on either Hera/Derecho/Hercules AND have committed the log to my PR branch.
  RegressionTests_hera.log

• Add list of all failed regression tests in "Regression Tests" section.

PR Information

Description

This PR adds three 3D soil variables (soilt, soilw and soill) to a history file if corresponding entries are specified in diag_table file. The new 3d versions of these variables is identical to a set of 2d variables currently available (soilt1, soilt2, etc). For example, replacing:

> "gfs_sfc",     "soilt1",      "soilt1"     "fv3_history2d",  "all",  .false.,  "none",  2
> "gfs_sfc",     "soilt2",      "soilt2"     "fv3_history2d",  "all",  .false.,  "none",  2
> "gfs_sfc",     "soilt3",      "soilt3"     "fv3_history2d",  "all",  .false.,  "none",  2
> "gfs_sfc",     "soilt4",      "soilt4"     "fv3_history2d",  "all",  .false.,  "none",  2
> "gfs_sfc",     "soilw1",      "soilw1"     "fv3_history2d",  "all",  .false.,  "none",  2
> "gfs_sfc",     "soilw2",      "soilw2"     "fv3_history2d",  "all",  .false.,  "none",  2
> "gfs_sfc",     "soilw3",      "soilw3"     "fv3_history2d",  "all",  .false.,  "none",  2
> "gfs_sfc",     "soilw4",      "soilw4"     "fv3_history2d",  "all",  .false.,  "none",  2
> "gfs_sfc",     "slc_1",       "soill1",    "fv3_history2d",  "all",  .false.,  "none",  2
> "gfs_sfc",     "slc_2",       "soill2",    "fv3_history2d",  "all",  .false.,  "none",  2
> "gfs_sfc",     "slc_3",       "soill3",    "fv3_history2d",  "all",  .false.,  "none",  2
> "gfs_sfc",     "slc_4",       "soill4",    "fv3_history2d",  "all",  .false.,  "none",  2

with

< "gfs_sfc",     "soilt",       "soilt"      "fv3_history2d",  "all",  .false.,  "none",  2
< "gfs_sfc",     "soilw",       "soilw"      "fv3_history2d",  "all",  .false.,  "none",  2
< "gfs_sfc",     "soill",       "soill",     "fv3_history2d",  "all",  .false.,  "none",  2

will write 3D version of the above soil variables to a history file

Commit Message

Add option to write 3d soilt, soilw and soill variables to a history file

Priority

• Critical Bugfix (This PR contains a critical bug fix and should be prioritized.)
• High (This PR contains a feature or fix needed for a time-sensitive project (eg, retrospectives, implementations))
• Normal

Blocking Dependencies

Git Issues Fixed By This PR

Closes #1055

Changes

Subcomponent (with links)

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3 Add option to write 3d soilt, soilw and soill variables to a history file NOAA-EMC/fv3atm#744
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Input data

• No changes are expected to input data.
• Changes are expected to input data:
  • New input data.
  • Updated input data.

Regression Tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests:

FAILED REGRESSION TESTS

control_CubedSphereGrid_parallel

Libraries

• Not Needed
• Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[FernandoAndrade-NOAA]

Hi @DusanJovic-NOAA, please go ahead and sync your branches with the latest develop, we'd like to get started on testing this PR next, thank you.

[DusanJovic-NOAA]

@FernandoAndrade-NOAA Done.

[FernandoAndrade-NOAA]

Gaea failed 4 tests, these failures do not look like standard timeouts. I'm checking up on the err to see what may be going on.

control_c384_intel 040 failed in run_test
control_decomp_p8_intel 053 failed in run_test
rap_sfcdiff_intel 072 failed in run_test
rap_noah_sfcdiff_cires_ugwp_debug_intel 110 failed in run_test

[FernandoAndrade-NOAA]

Gaea failed 4 tests, these failures do not look like standard timeouts. I'm checking up on the err to see what may be going on.

control_c384_intel 040 failed in run_test
control_decomp_p8_intel 053 failed in run_test
rap_sfcdiff_intel 072 failed in run_test
rap_noah_sfcdiff_cires_ugwp_debug_intel 110 failed in run_test

rundir: /gpfs/f5/epic/scratch/Fernando.Andrade-maldonado/FV3_RT/rt_238940/

[FernandoAndrade-NOAA]

@jkbk2004 @zach1221 FYI, the control_c384 intel rerun with develop passed, so the issues may be coming from the PR updates. It should also be noted that gaea seems to have a bit of performance degradation since last night.

[FernandoAndrade-NOAA]

Given the recent email regarding issues with Gaea jobs failing after yesterday's maintenance that should now be resolved, I'm rerunning the failed tests to verify if it was just a system issue.

[FernandoAndrade-NOAA]

Double checking the log diff, the rap_sfcdiff_restart is missing from the Gaea log, likely due to the issues from the maintenance. I'm rerunning that as well. The other 4 reported test failures passed fine this time and have their success appended to the Gaea log.

[FernandoAndrade-NOAA]

Ok, I think we're good to continue with the merge process in the fv3 sub pr. @zach1221 FYI

[zach1221]

@DusanJovic-NOAA fv3atm pr is merged. Please update hash and revert .gitmodule url.
NOAA-EMC/fv3atm@0fe9ba3