Update WW3 for PIO/netCDF restarts #2445

DeniseWorthen · 2024-09-24T17:26:21Z

Commit Queue Requirements:

Fill out all sections of this template.
All sub component pull requests have been reviewed by their code managers.
Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
Commit 'test_changes.list' from previous step

Description:

Commit Message:

* UFSWM - add PIO settings to WAV attributes in ufs.configure templates
* UFSWM - update ww3_shel.nml to allow for the ice field to be written to the restart file when required (i.e, waves in the slow loop)
* UFSWM - add WW3 restart files to comparison lists
  * WW3 - Add netCDF PIO capability for restarts and run-time history

Priority:

High - required for GFSv17

Git Tracking

UFSWM:

Closes Add netcdf restart and history files using PIO (parallel netCDF) for dev/ufs-weather-model NOAA-EMC/WW3#1298

Sub component Pull Requests:

WW3: Add netCDF PIO capability for restarts and run-time history for dev/ufs-weather-model NOAA-EMC/WW3#1303

UFSWM Blocking Dependencies:

Changes

Regression Test Changes (Please commit test_changes.list):

PR Updates/Changes Baselines.

New Baselines are required for all tests which include the WAV component. Answers do not change, but the comparison lists will now include a WW3 netCDF restart file. Note we do not currently compare the WW3 binary restart files for any global coupled test because they don't in general reproduce themselves.

To verify no answer changes, the WW3 restarts were temporarily removed from comparison lists but with netcdf restarts written and used for restart tests. All baselines passed against the develop-20240909 on hercules at 0b0a048

I've continued to test this PR against the current develop branch using the method of temporarily removing the netCDF WW3 restart files from the comparison lists. This feature branch has continued to pass as the final changes were made to the WW3 feature branch, most recently using 79cfd42.

I've also created a baseline using this PR at the above hash and verified against it. In this case, the netCDF restart files are being compared. All baselines pass.

In testing, it was found that Hercules+GNU failed for the subset rearranger, but worked for box. The relevant tests were switched to box only for Hercules+GNU tests. To verify that the problem is a platform (Hercules) issue, GNU tests were then run on Derecho against a self-baseline and all tests passed at 677cfd9.

rt_cpld_control_nowave_noaero_p8_gnu.log:Test cpld_control_nowave_noaero_p8_gnu PASS
rt_cpld_control_p8_gnu.log:Test cpld_control_p8_gnu PASS
rt_cpld_control_pdlib_p8_gnu.log:Test cpld_control_pdlib_p8_gnu PASS
rt_cpld_debug_p8_gnu.log:Test cpld_debug_p8_gnu PASS
rt_cpld_debug_pdlib_p8_gnu.log:Test cpld_debug_pdlib_p8_gnu PASS

On Hercules, a full RT test_changes.list has been committed. Examining the log files shows test failues are due to missing netCDF WW3 restarts. For these tests, no files were found to 'not compare'.

rt_atmwav_control_noaero_p8_intel.log: Comparing ufs.atmw.ww3.r.2021-03-22-64800.nc ............MISSING baseline
rt_cpld_2threads_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600.nc ............MISSING baseline
rt_cpld_bmark_p8_intel.log: Comparing ufs.cpld.ww3.r.2013-04-01-21600.nc ............MISSING baseline
rt_cpld_control_c192_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-43200.nc ............MISSING baseline
rt_cpld_control_ciceC_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600.nc ............MISSING baseline
rt_cpld_control_gfsv17_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600.nc ............MISSING baseline
rt_cpld_control_noaero_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600.nc ............MISSING baseline
rt_cpld_control_p8.v2.sfc_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600.nc ............MISSING baseline
rt_cpld_control_p8_faster_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600.nc ............MISSING baseline
rt_cpld_control_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600.nc ............MISSING baseline
rt_cpld_control_p8_mixedmode_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600.nc ............MISSING baseline
rt_cpld_control_pdlib_p8_gnu.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600.nc ............MISSING baseline
rt_cpld_control_pdlib_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600.nc ............MISSING baseline
rt_cpld_control_qr_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600.nc ............MISSING baseline
rt_cpld_debug_gfsv17_intel.log: Comparing ufs.cpld.ww3.r.2021-03-22-32400.nc ............MISSING baseline
rt_cpld_debug_noaero_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-22-32400.nc ............MISSING baseline
rt_cpld_debug_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-22-32400.nc ............MISSING baseline
rt_cpld_debug_pdlib_p8_gnu.log: Comparing ufs.cpld.ww3.r.2021-03-22-32400.nc ............MISSING baseline
rt_cpld_debug_pdlib_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-22-32400.nc ............MISSING baseline
rt_cpld_decomp_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600.nc ............MISSING baseline
rt_cpld_mpi_gfsv17_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600.nc ............MISSING baseline
rt_cpld_mpi_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600.nc ............MISSING baseline
rt_hafs_regional_atm_ocn_wav_intel.log: Comparing ufs.hafs.ww3.r.2019-08-29-21600.nc ............MISSING baseline
rt_hafs_regional_atm_wav_intel.log: Comparing ufs.hafs.ww3.r.2019-08-29-21600.nc ............MISSING baseline

Input data Changes:

None

Testing Log:

at cc70186, the following files do not compare rt_cpld_mpi_gfsv17_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600 .....USING CMP......NOT IDENTICAL rt_cpld_mpi_pdlib_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600 .....USING CMP......NOT IDENTICAL rt_cpld_restart_bmark_p8_intel.log: Comparing ufs.cpld.ww3.r.2013-04-01-21600 .....USING CMP......NOT IDENTICAL rt_cpld_restart_c192_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-43200 .....USING CMP......NOT IDENTICAL

*add trho fix to w3iors, these ww3.r files do not compare *tested against bl.trhofix rt_cpld_mpi_gfsv17_intel.log:Test cpld_mpi_gfsv17_intel FAIL rt_cpld_mpi_pdlib_p8_intel.log:Test cpld_mpi_pdlib_p8_intel FAIL rt_cpld_restart_bmark_p8_intel.log:Test cpld_restart_bmark_p8_intel FAIL rt_cpld_restart_c192_p8_intel.log:Test cpld_restart_c192_p8_intel FAIL

* no write/read of fpis. these ww3.r files do not compare. tested against bl.trhofix.nofpis. all other files compare b4b rt_cpld_mpi_gfsv17_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600 .....USING CMP......NOT IDENTICAL rt_cpld_mpi_pdlib_p8_intel.log: Comparing ufs.cpld.ww3.r.2021-03-23-21600 .....USING CMP......NOT IDENTICAL

* fix typo in use_historync * remove mediator_present flag (unneeded)

* following pass baseline cpld_debug_noaero_p8 cpld_debug_pdlib_p8 hafs_regional_storm_following_1nest_atm_ocn_wav_mom6

* tested all wave-containing tests with modifications for restart file naming to allow for the custom filenaming of binary restarts. This feature is present in the current WW3 code, but will be removed once we enable netcdf restarts. Temporary code was added to allow the binary restart to have the existing format of casename+ww3.r+timestring. With this modification, all baselines were B4B.

…ure/pio4ww3

* ww3 hash 4674dae passes against a self-generated baseline except for cpld_restart_gfsv17_intel * compare cmeps restart files of this uwm-hash against current baseline at develop-20240904. All are identical except for cpld_control_gfsv17_iau_intel

* ww3 0ad634c9 still fails slow restart, even though my sandbox testing passed.

* additional restart fields for WW3/slow loop coupling are requested via ww3 nml setting

FernandoAndrade-NOAA · 2024-11-13T18:50:37Z

Leaving a note that Orion is consistently failing hafs_regional_atm_ocn_wav_intel during baseline creation runtime due to time limit, I'm rerunning with an increased time limit. Gaea RTs showed changes in intelllvm tests as well. They've been regenerated and are rerunning. Jet is still running.

DeniseWorthen · 2024-11-13T18:55:45Z

@FernandoAndrade-NOAA Can you confirm that the Gaea LLVM RTs failed because the WW3 netcdf restarts would have been missing from the baseline?

FernandoAndrade-NOAA · 2024-11-13T18:56:28Z

@FernandoAndrade-NOAA Can you confirm that the Gaea LLVM RTs failed because the WW3 netcdf restarts would have been missing from the baseline?

Correct, the errors in the logs were due to missing baselines.

jkbk2004 · 2024-11-14T16:32:48Z

Baseline develop-20241112 was created ok on Derecho: /glade/derecho/scratch/epicufsrt/ufs-weather-model/RT/NEMSfv3gfs/develop-20241112. Due to ecflow and rocoto issue on the machine, we will skip Derecho RT log.

jkbk2004 · 2024-11-14T17:35:15Z

anyway, regarding derecho ecflow issue:

Error: request( --begin=regtest_14784 ) failed!  Server reply: BeginCmd::doHandleRequest:  Begin failed as suite 'regtest_14784' is not loaded.

in contact with sys admin. Rocoto issue on derecho: rocotorun and rocotstat iteration gets stuck with long list of jobs.

FernandoAndrade-NOAA · 2024-11-14T18:23:06Z

Ok, we should be all set then. I'll leave a note in the subcomponent PR.

DeniseWorthen and others added 30 commits July 27, 2024 15:14

add ww3 restarts to comparison lists

e73197a

Merge branch 'ufs-community:develop' into feature/fixww3restart

cc70186

update WW3

22033bf

create branch for WW3 netcdf work

b089f61

fix ufs.configs

bf0297a

* fix typo in use_historync * remove mediator_present flag (unneeded)

Merge branch 'ufs-community:develop' into feature/pio4ww3

996a425

update WW3, config parameters

49f7a65

baseline test, ww3 0ece778b

6ef68ce

* following pass baseline cpld_debug_noaero_p8 cpld_debug_pdlib_p8 hafs_regional_storm_following_1nest_atm_ocn_wav_mom6

fix whitespace in config variables

a5f2fb5

update ww3

98435ca

Merge branch 'develop' into feature/fixww3restart

641946c

Merge branch 'develop' into feature/fixww3restart

e297fa1

Merge branch 'ufs-community:develop' into feature/pio4ww3

a7aa31f

Merge branch 'ufs-community:develop' into feature/fixww3restart

3b29d4f

Merge remote-tracking branch 'origin/feature/fixww3restart' into feat…

5003ad6

…ure/pio4ww3

update tests and settings to use ww3 netcdf restarts

99719e6

update WW3 and remove stride from ww3 nml

38ac9b8

Merge branch 'ufs-community:develop' into feature/pio4ww3

c14a5c3

update WW3

2d0125e

Merge branch 'ufs-community:develop' into feature/pio4ww3

e014745

update WW3

db86288

update WW3

c404fd4

test b4b against generated baseline

55bb211

* ww3 hash 4674dae passes against a self-generated baseline except for cpld_restart_gfsv17_intel * compare cmeps restart files of this uwm-hash against current baseline at develop-20240904. All are identical except for cpld_control_gfsv17_iau_intel

add couple_slow for testing

46586e5

b4b test for feature/debugslow

efb3ad5

* ww3 0ad634c9 still fails slow restart, even though my sandbox testing passed.

remove couple_slow and use nml setting

c8cda3b

* additional restart fields for WW3/slow loop coupling are requested via ww3 nml setting

DeniseWorthen added 2 commits November 12, 2024 16:13

Merge branch 'ufs-community:develop' into develop

fbe0495

Merge remote-tracking branch 'origin/develop' into feature/pio4ww3

c3c717b

FernandoAndrade-NOAA added the Baseline Updates Current baselines will be updated. label Nov 12, 2024

Update bl_date.conf

a455d4d

FernandoAndrade-NOAA added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ort run ORT testing and removed jenkins-ort run ORT testing labels Nov 12, 2024

FernandoAndrade-NOAA and others added 2 commits November 13, 2024 15:42

add hera RT log passed

fdd8391

add hercules RT log passed

becb101

BrianCurtis-NOAA and others added 3 commits November 13, 2024 20:41

WCOSS2 RT Log: Passed

8408059

add gaea RT log passed

08f11c8

orion log with test_changes and wlclk

5ec7c10

add jet RT log passed

b7453e7

FernandoAndrade-NOAA and others added 2 commits November 14, 2024 11:27

Update hafs_regional_atm_ocn_wav remove extra newlines

e75a7ce

update WW3 and revert gitmodules

689ce2c

FernandoAndrade-NOAA requested review from jkbk2004 and BrianCurtis-NOAA November 14, 2024 18:38

jkbk2004 approved these changes Nov 14, 2024

View reviewed changes

jkbk2004 requested a review from NickSzapiro-NOAA November 14, 2024 20:31

NickSzapiro-NOAA approved these changes Nov 14, 2024

View reviewed changes

NickSzapiro-NOAA assigned DeniseWorthen Nov 14, 2024

jkbk2004 requested a review from FernandoAndrade-NOAA November 14, 2024 20:42

FernandoAndrade-NOAA approved these changes Nov 14, 2024

View reviewed changes

FernandoAndrade-NOAA merged commit 6b0f516 into ufs-community:develop Nov 14, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update WW3 for PIO/netCDF restarts #2445

Update WW3 for PIO/netCDF restarts #2445

DeniseWorthen commented Sep 24, 2024 •

edited by FernandoAndrade-NOAA

Loading

FernandoAndrade-NOAA commented Nov 13, 2024

DeniseWorthen commented Nov 13, 2024

FernandoAndrade-NOAA commented Nov 13, 2024

jkbk2004 commented Nov 14, 2024

jkbk2004 commented Nov 14, 2024

FernandoAndrade-NOAA commented Nov 14, 2024

Update WW3 for PIO/netCDF restarts #2445

Update WW3 for PIO/netCDF restarts #2445

Conversation

DeniseWorthen commented Sep 24, 2024 • edited by FernandoAndrade-NOAA Loading

Commit Queue Requirements:

Description:

Commit Message:

Priority:

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

Changes

Regression Test Changes (Please commit test_changes.list):

Input data Changes:

Testing Log:

FernandoAndrade-NOAA commented Nov 13, 2024

DeniseWorthen commented Nov 13, 2024

FernandoAndrade-NOAA commented Nov 13, 2024

jkbk2004 commented Nov 14, 2024

jkbk2004 commented Nov 14, 2024

FernandoAndrade-NOAA commented Nov 14, 2024

DeniseWorthen commented Sep 24, 2024 •

edited by FernandoAndrade-NOAA

Loading