Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to chgres_cube from integration with SRW #610

Merged
merged 13 commits into from
Oct 14, 2024

Conversation

WeirAE
Copy link
Contributor

@WeirAE WeirAE commented Oct 8, 2024

Synopsis

A set of changes to the drivers run as part of SRW's make_ics/make_lbcs task.

Minor changes to the UW YAML to remove additional properties and add one type
Reference configs reorganized to reflect expected make_ics namelist
Logic changes for file path handling in chgres_cube to account for strict key path references

Currently failing test coverage due to changes.

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

test coverage failing
docs/shared/chgres_cube.yaml Outdated Show resolved Hide resolved
src/uwtools/drivers/chgres_cube.py Outdated Show resolved Hide resolved
src/uwtools/drivers/chgres_cube.py Show resolved Hide resolved
src/uwtools/drivers/chgres_cube.py Show resolved Hide resolved
src/uwtools/resources/jsonschema/chgres-cube.jsonschema Outdated Show resolved Hide resolved
src/uwtools/tests/drivers/test_chgres_cube.py Show resolved Hide resolved
Copy link
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review all of the code, just the logic for the namelist checks.

docs/shared/chgres_cube.yaml Show resolved Hide resolved
docs/shared/chgres_cube.yaml Outdated Show resolved Hide resolved
docs/shared/chgres_cube.yaml Outdated Show resolved Hide resolved
src/uwtools/drivers/chgres_cube.py Outdated Show resolved Hide resolved
@WeirAE
Copy link
Contributor Author

WeirAE commented Oct 10, 2024

So, Python 3.13 just dropped and it depreciates imghdr, which is used in older versions of sphinx. Currently we're requiring sphinx_rtd_theme=2.0.* and sphinxcontrib-bibtex=2.6.*. Current versions are 3.0 and 2.6.3, respectively. I think the fix is to bump to sphinx_rtd_theme=3.0.* because sphinx didn't fix it until the latest version

docs/environment.yml Outdated Show resolved Hide resolved
src/uwtools/resources/jsonschema/chgres-cube.jsonschema Outdated Show resolved Hide resolved
src/uwtools/resources/jsonschema/chgres-cube.jsonschema Outdated Show resolved Hide resolved
src/uwtools/drivers/chgres_cube.py Outdated Show resolved Hide resolved
WeirAE and others added 2 commits October 10, 2024 13:13
Co-authored-by: Christina Holt <56881914+christinaholtNOAA@users.noreply.github.com>
@WeirAE
Copy link
Contributor Author

WeirAE commented Oct 14, 2024

I was holding for another possible fix, but I think that can be added later - thanks for the help

@WeirAE WeirAE merged commit a802a35 into ufs-community:main Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants