Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose schism, ww3 drivers to CLI #613

Merged
merged 12 commits into from
Oct 21, 2024
Merged

Expose schism, ww3 drivers to CLI #613

merged 12 commits into from
Oct 21, 2024

Conversation

maddenp-noaa
Copy link
Collaborator

Fixes #608. See issue for details.

Type

  • Documentation
  • Enhancement (adds new functionality)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Oct 21, 2024
maddenp-noaa
maddenp-noaa commented Oct 21, 2024
View reviewed changes
docs/conf.py Show resolved Hide resolved
docs/conf.py Show resolved Hide resolved
docs/sections/user_guide/cli/drivers/cdeps/show-schema.cmd Outdated Show resolved Hide resolved
docs/sections/user_guide/cli/drivers/schism/Makefile Show resolved Hide resolved
docs/sections/user_guide/cli/drivers/cdeps/show-schema.cmd Show resolved Hide resolved
@maddenp-noaa maddenp-noaa marked this pull request as ready for review October 21, 2024 20:19
christinaholtNOAA
christinaholtNOAA approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

WeirAE
WeirAE approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maddenp-noaa maddenp-noaa merged commit 8f317d6 into ufs-community:main Oct 21, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the gh608-all-drivers-to-cli branch October 21, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@WeirAE WeirAE WeirAE approved these changes

@christinaholtNOAA christinaholtNOAA christinaholtNOAA approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA Awaiting requested review from NaureenBharwaniNOAA NaureenBharwaniNOAA is a code owner

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr

@Byrnetp Byrnetp Awaiting requested review from Byrnetp Byrnetp is a code owner

Assignees

@maddenp-noaa maddenp-noaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider exposing all drivers to CLI to support --show-schema
4 participants
@maddenp-noaa @christinaholtNOAA @WeirAE @elcarpenterNOAA