-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp config compare for compatibility with more configs #654
Merged
maddenp-noaa
merged 26 commits into
ufs-community:main
from
maddenp-noaa:gh622-sh-compare-fix
Nov 15, 2024
Merged
Revamp config compare for compatibility with more configs #654
maddenp-noaa
merged 26 commits into
ufs-community:main
from
maddenp-noaa:gh622-sh-compare-fix
Nov 15, 2024
+385
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddenp-noaa
commented
Nov 15, 2024
maddenp-noaa
requested review from
NaureenBharwaniNOAA,
christinaholtNOAA,
elcarpenterNOAA and
fgabelmannjr
as code owners
November 15, 2024 00:11
christinaholtNOAA
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Geez! You really went above and beyond on the bug fix. The user experience upgrade and the clean solution are fantastic!
maddenp-noaa
commented
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
Fixes #622.
In addition to fixing the compare-two-identical-
.sh
-configs example from the ticket,.sh
configs with differences are now handled, with differences shown using a familiar diff syntax:a.sh
b.sh
Also, depth > 2 configs, which also were not previously processed, now work:
a.yaml
b.yaml
Mixed-depth configs work:
c.yaml
Namelist configs are compared via their YAML representations:
a.nml
b.nml
Unit tests are updated/expanded, and docs are updated.
This may be considered a breaking change because the logged output is different.
Type
Impact
Checklist