Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an output method for the chgres_cube driver #674

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Add an output method for the chgres_cube driver #674

merged 4 commits into from
Dec 13, 2024

Conversation

Byrnetp
Copy link
Collaborator

@Byrnetp Byrnetp commented Dec 12, 2024

Synopsis

Fixes #636.

Type

  • Enhancement (adds new functionality)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@Byrnetp Byrnetp self-assigned this Dec 12, 2024
maddenp-noaa
maddenp-noaa approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@maddenp-noaa maddenp-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I made one small suggestion.

src/uwtools/drivers/chgres_cube.py Outdated Show resolved Hide resolved
Byrnetp and others added 2 commits December 12, 2024 09:49
@Byrnetp @maddenp-noaa
Update src/uwtools/drivers/chgres_cube.py
7d0c365 
Use lowercase key

Co-authored-by: Paul Madden <136389411+maddenp-noaa@users.noreply.github.com>
@Byrnetp
Change key to lowercase
5c4547b
@Byrnetp Byrnetp merged commit 3cc9ab5 into ufs-community:main Dec 13, 2024
2 checks passed
@Byrnetp Byrnetp deleted the chgres-cube-output branch December 13, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddenp-noaa maddenp-noaa maddenp-noaa approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA Awaiting requested review from NaureenBharwaniNOAA NaureenBharwaniNOAA is a code owner

@christinaholtNOAA christinaholtNOAA Awaiting requested review from christinaholtNOAA christinaholtNOAA is a code owner

@elcarpenterNOAA elcarpenterNOAA Awaiting requested review from elcarpenterNOAA elcarpenterNOAA is a code owner

Assignees

@Byrnetp Byrnetp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output method for chgres_cube driver.
2 participants
@Byrnetp @maddenp-noaa