Fix PMD warnings.

uhafner · Oct 5, 2024 · a8676cb · a8676cb
1 parent 82ebe9c
commit a8676cb
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/main/java/edu/hm/hafner/grading/AnalysisScore.java b/src/main/java/edu/hm/hafner/grading/AnalysisScore.java
@@ -146,7 +146,7 @@ protected String createSummary() {
         }
         else {
             var warnings = format("%d %s", getTotalSize(), getItemCount(getTotalSize()));
-            var details = Severity.getPredefinedValues()
+            var details = getPredefinedValues()
                     .stream()
                     .map(this::reportSeverity)
                     .flatMap(Optional::stream)
@@ -180,7 +180,10 @@ private String getItemName() {
     }
 
     static String plural(final int score) {
-        return score != 1 ? "s" : "";
+        if (score == 1) {
+            return StringUtils.EMPTY;
+        }
+        return "s";
     }
 
     @Override @Generated