Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon parameter for tools. #391

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Add icon parameter for tools. #391

merged 1 commit into from
Nov 3, 2024

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented Nov 2, 2024

Refactor icon handling:

  1. check the icon of the tool
  2. check the specific icon in the registry
  3. check the icon of the configuration
  4. dallback: default icon of markdown class

@uhafner uhafner added the enhancement Enhancement of existing functionality label Nov 2, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 90.09901% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@1e83231). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...main/java/edu/hm/hafner/grading/CoverageScore.java 76.47% 3 Missing and 1 partial ⚠️
...n/java/edu/hm/hafner/grading/CoverageMarkdown.java 57.14% 2 Missing and 1 partial ⚠️
.../hafner/grading/FileSystemMetricReportFactory.java 0.00% 1 Missing ⚠️
.../main/java/edu/hm/hafner/grading/TestMarkdown.java 93.33% 0 Missing and 1 partial ⚠️
src/main/java/edu/hm/hafner/grading/TestScore.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage        ?   85.79%           
  Complexity      ?      478           
=======================================
  Files           ?       30           
  Lines           ?     1401           
  Branches        ?       82           
=======================================
  Hits            ?     1202           
  Misses          ?      167           
  Partials        ?       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner force-pushed the move-icon branch 2 times, most recently from 03159dd to 9392614 Compare November 3, 2024 15:34
Repository owner deleted a comment from github-actions bot Nov 3, 2024
Repository owner deleted a comment from github-actions bot Nov 3, 2024
Refactor icon handling:
1. check the icon of the tool
2. check the specific icon in the registry
3. check the icon of the configuration
4. dallback: default icon of markdown class
Repository owner deleted a comment from github-actions bot Nov 3, 2024
Copy link

github-actions bot commented Nov 3, 2024

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 162 passed)
   〰️   Line Coverage: 88% (167 missed lines)
   ➰   Branch Coverage: 85% (58 missed branches)
   PIT   Mutation Coverage: 78% (169 survived mutations)
   🔬   Test Strength: 88% (85 survived mutations in tested code)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No bugs
   🐛   Error Prone: No bugs
   OWASP Dependency Check   OWASP Dependency Check: 1 vulnerability (normal: 1)
   🌀   Cyclomatic Complexity: 567
   💡   Cognitive Complexity: 226
   📝   Non Commenting Source Statements: 1998
   ➿   N-Path Complexity: 1046


Created by Quality Monitor v1.12.0 (#910ef11). More details are shown in the GitHub Checks Result.

@uhafner uhafner merged commit 91105da into main Nov 3, 2024
16 checks passed
@uhafner uhafner deleted the move-icon branch November 3, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant