Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new class that can extract files from a classloader classpath #554

Merged
merged 5 commits into from
May 14, 2022

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented May 13, 2022

The new ResourceExtractor supports both class loaders that use Jar files (deployed components) or folders (classes in development environment or Maven build).

@lgtm-com
Copy link

lgtm-com bot commented May 13, 2022

This pull request introduces 1 alert when merging c41d89c into d23b1f9 - view on LGTM.com

new alerts:

  • 1 for Arbitrary file write during archive extraction ("Zip Slip")

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2022

Codecov Report

Merging #554 (ccaad24) into main (d23b1f9) will increase coverage by 0.71%.
The diff coverage is 91.30%.

@@             Coverage Diff              @@
##               main     #554      +/-   ##
============================================
+ Coverage     89.83%   90.54%   +0.71%     
- Complexity       98      109      +11     
============================================
  Files             9       10       +1     
  Lines           354      423      +69     
  Branches         50       59       +9     
============================================
+ Hits            318      383      +65     
- Misses           29       32       +3     
- Partials          7        8       +1     
Impacted Files Coverage Δ
...ain/java/edu/hm/hafner/util/ResourceExtractor.java 91.30% <91.30%> (ø)
...ava/edu/hm/hafner/util/NoSuchElementException.java 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23b1f9...ccaad24. Read the comment docs.

@uhafner uhafner merged commit 21b8ff7 into main May 14, 2022
@uhafner uhafner deleted the resource-extractor branch May 14, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants