Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove equals from FilteredLog #755

Merged
merged 4 commits into from
May 9, 2023
Merged

Remove equals from FilteredLog #755

merged 4 commits into from
May 9, 2023

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented May 8, 2023

We should never compare 2 instances.

@uhafner uhafner added the internal Internal changes without user or API impact label May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2f8b79b) 91.71% compared to head (93fcde1) 91.71%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #755   +/-   ##
=========================================
  Coverage     91.71%   91.71%           
  Complexity      135      135           
=========================================
  Files             9        9           
  Lines           531      531           
  Branches         64       64           
=========================================
  Hits            487      487           
  Misses           35       35           
  Partials          9        9           
Impacted Files Coverage Δ
src/main/java/edu/hm/hafner/util/FilteredLog.java 98.33% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@uhafner uhafner merged commit c5c70b4 into main May 9, 2023
@uhafner uhafner deleted the no-equals-filtered-log branch May 9, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes without user or API impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant