Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override equals for FilteredLog #851

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Override equals for FilteredLog #851

merged 2 commits into from
Nov 16, 2023

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented Nov 10, 2023

Helps to improve tests that use the logger.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Nov 10, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8858d4f) 88.67% compared to head (b17e9ce) 88.85%.
Report is 16 commits behind head on main.

Files Patch % Lines
src/main/java/edu/hm/hafner/util/FilteredLog.java 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #851      +/-   ##
============================================
+ Coverage     88.67%   88.85%   +0.17%     
- Complexity      164      173       +9     
============================================
  Files            11       11              
  Lines           689      709      +20     
  Branches         85       90       +5     
============================================
+ Hits            611      630      +19     
  Misses           63       63              
- Partials         15       16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner merged commit 38244ac into main Nov 16, 2023
18 checks passed
@uhafner uhafner deleted the filtered-log-equals branch November 16, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant