Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useSref: "target="_blank" ignored when link contains child elements #1224

Open
mishra-ankit-learn opened this issue Mar 20, 2024 · 1 comment

Comments

@mishra-ankit-learn
Copy link

mishra-ankit-learn commented Mar 20, 2024

@mishra-ankit-learn mishra-ankit-learn changed the title useSref: Do not handle clicks when anchor element has a child element inside it useSref: "target="_blank" ignored when link contains child elements Mar 20, 2024
mishra-ankit-learn added a commit to mishra-ankit-learn/ui-router-react that referenced this issue Mar 22, 2024
…ntProperty rather than from target so that browser's onClick can be used in cases where anchor has a child
@mishra-ankit-learn
Copy link
Author

mishra-ankit-learn commented Mar 22, 2024

Created PR: #1226 to fix the issue.

Added unit test too

mishra-ankit-learn added a commit to mishra-ankit-learn/ui-router-react that referenced this issue Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant