Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OnUkadocExampleScript to External SHIORI Events list #36

Merged
merged 2 commits into from
Dec 31, 2023

Conversation

Zichqec
Copy link
Member

@Zichqec Zichqec commented Dec 31, 2023

I added a listing for OnUkadocExampleScript. Translation was done with DeepL, please check it! 🙇

@Zichqec Zichqec requested a review from nikolat December 31, 2023 06:23
Copy link
Member

@nikolat nikolat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good.
I would like you to correct the following.

manual/list_shiori_event_ex.html Outdated Show resolved Hide resolved
Co-authored-by: Don <evidence@384.jp>
Copy link
Member

@nikolat nikolat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nikolat nikolat merged commit 1248257 into master Dec 31, 2023
1 check passed
@nikolat nikolat deleted the OnUkadocExampleScript branch December 31, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants