Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require numpy 1 due to incompatibility with Streamlit #335

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

tkoskela
Copy link
Member

Update bokeh version to work with latest numpy

Closes #334

Update bokeh version to work with latest numpy

Closes #334
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I don't know why we were pinning an exact (and quite old) version. Latest version at the moment is 3.5.0.

@tkoskela
Copy link
Member Author

I actually meant to use >= not ==, let me fix

@tkoskela
Copy link
Member Author

Ah, there was a reason for that specific version. This could be a problem

StreamlitAPIException: Streamlit only supports Bokeh version 2.4.3, but you have version 3.5.0 installed. Please run pip install --force-reinstall --no-deps bokeh==2.4.3 to install the correct version.

Copy link
Collaborator

@pineapple-cat pineapple-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to use Bokeh v2.4.3 so it doesn't break Streamlit. Can we just cap the numpy version below 2.0.0 for now?

Copy link
Collaborator

@pineapple-cat pineapple-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test failure that's happening now is the same one as in the line plot PR, but I can't quite tell what's causing it at a glance. Maybe there's another library we need to version cap – pandas perhaps?

@tkoskela
Copy link
Member Author

It's failing on

    assert all(c in EXPECTED_FIELDS for c in df.columns.tolist())

On a quick look through the perflog the fields look ok. Maybe something has changed in the spac spec dict?

@pineapple-cat
Copy link
Collaborator

If it helps, I think the change causing this may have taken place 28 - 29 May. Using the line plot PR as reference again, all tests were passing on the 28th, but when I pushed some inconsequential changes on the 29th this specific test started failing.

@tkoskela
Copy link
Member Author

tkoskela commented Jul 22, 2024

The field version has changed to reframe version (I assume in a new version of ReFrame). I'm running 4.6.2. I updated it in the test and now it passes. I noticed we don't have whitespace in other field names. Is that going to cause any issues @pineapple-cat?

Edit: I should probably update the required version of ReFrame with this.

@pineapple-cat
Copy link
Collaborator

Of course, I forgot about ReFrame field name updates; thank you for finding the issue.

Copy link
Collaborator

@pineapple-cat pineapple-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The presence of whitespace in "reframe version" bothers me on a psychological level, but I don't think there's anything in our config handler that explicitly can't handle it. We may want to replace all whitespace with an underscore to ensure consistency in label handling for later stages, but it's not strictly necessary. I just ran some tests with whitespace in field names and the resulting graphs look fine.

@giordano giordano changed the title Update pyproject.toml Require numpy 1 due to incompatibility with Bokeh Jul 22, 2024
@giordano giordano changed the title Require numpy 1 due to incompatibility with Bokeh Require numpy 1 due to incompatibility with Streamlit Jul 22, 2024
@tkoskela
Copy link
Member Author

This change seems to have happened in ReFrame 4.6.1. Are we happy to update the requirement to that?

@giordano
Copy link
Member

I think so. Better to be explicit about the actually supported versions.

@tkoskela tkoskela merged commit 2c47c1f into main Jul 22, 2024
4 checks passed
@tkoskela tkoskela deleted the tkoskela-patch-1 branch July 22, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post-processing breaks with numpy/2.0.0
3 participants