-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require numpy 1 due to incompatibility with Streamlit #335
Conversation
Update bokeh version to work with latest numpy Closes #334
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I don't know why we were pinning an exact (and quite old) version. Latest version at the moment is 3.5.0.
I actually meant to use |
Ah, there was a reason for that specific version. This could be a problem
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need to use Bokeh v2.4.3 so it doesn't break Streamlit. Can we just cap the numpy version below 2.0.0 for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the test failure that's happening now is the same one as in the line plot PR, but I can't quite tell what's causing it at a glance. Maybe there's another library we need to version cap – pandas perhaps?
It's failing on
On a quick look through the perflog the fields look ok. Maybe something has changed in the spac spec dict? |
If it helps, I think the change causing this may have taken place 28 - 29 May. Using the line plot PR as reference again, all tests were passing on the 28th, but when I pushed some inconsequential changes on the 29th this specific test started failing. |
The field Edit: I should probably update the required version of ReFrame with this. |
Of course, I forgot about ReFrame field name updates; thank you for finding the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The presence of whitespace in "reframe version" bothers me on a psychological level, but I don't think there's anything in our config handler that explicitly can't handle it. We may want to replace all whitespace with an underscore to ensure consistency in label handling for later stages, but it's not strictly necessary. I just ran some tests with whitespace in field names and the resulting graphs look fine.
This change seems to have happened in ReFrame |
I think so. Better to be explicit about the actually supported versions. |
Update bokeh version to work with latest numpy
Closes #334