Helpdesk integration #2159
Open
Helpdesk integration #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossmiller
force-pushed
the
helpdesk-integration
branch
from
0f9dba9 to
3218531
Compare
|
@agalamatis I've tidied up a bit. We need to fix the linting and the rest of the tests. We also need to safely remove all references to Zendesk settings that are no longer needed. |
|
@agalamatis also, removing any refs to Zendesk in var names etc, |
rossmiller
reviewed
Sep 21, 2022
rossmiller
reviewed
Sep 21, 2022
rossmiller
reviewed
Sep 21, 2022
rossmiller
force-pushed
the
helpdesk-integration
branch
2 times, most recently
from
d2a57c8 to
fcb81d7
Compare
rossmiller
force-pushed
the
helpdesk-integration
branch
from
954f826 to
74fde12
Compare
rossmiller
force-pushed
the
helpdesk-integration
branch
from
4789b5e to
a0228df
Compare
rossmiller
reviewed
Oct 5, 2022
| @@ -37,8 +37,7 @@ docker-test-unit: docker-build | |||
|
|
|||
| .PHONY: docker-test-integration | |||
| docker-test-integration: docker-build | |||
| docker-compose -f docker-compose-test.yml -p data-workspace-test run data-workspace-test pytest test/ | |||
|
|
|||
| docker-compose -f docker-compose-test.yml -p data-workspace-test run -e DJANGO_SETTINGS_MODULE=dataworkspace.settings.integration_tests data-workspace-test pytest test/ | |||
There was a problem hiding this comment.
I added the integration settings module as an env var as this command was using the base settings originally.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.