Refactor: Only use SQLAlchemy when setting up permissions. #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy up the code to have one consistent way of setting up a database user. Also a small stepping stone to setting more timeouts and incorpirating more functionality in pg-sync-roles. which is sqlalchemy based. Co-authored-by: Mohizur Khan <mohizur.khan@digital.trade.gov.uk> Co-authored-by: Michal Charemza <michal@charemza.name>
michalc
force-pushed
the
refactor/only-use-sql-alchemy-when-setting-up-permissions
branch
from
c37eab6 to
29a771f
Compare
michalc
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Tidy up the code to have one consistent way of setting up a database user. Also a small stepping stone to setting more timeouts and incorporating more functionality in pg-sync-roles. which is SQLAlchemy based.
This also increases the isolation between setting up users(which we use SQLAlchemy) and running queries(which we use Django).
Checklist