Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ltd 5424 tidy up email payloads #2178

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Ltd 5424 tidy up email payloads #2178

merged 2 commits into from
Sep 17, 2024

Conversation

kevincarrogan
Copy link
Contributor

@kevincarrogan kevincarrogan commented Sep 12, 2024 •
edited by jira bot
Loading

Aim

When looking to update the URLs for the public beta switch over it was hard to decipher what was a used template variable and/or a used template. This should remove both templates and template variables that aren’t being used.

LTD-5424

@kevincarrogan kevincarrogan force-pushed the LTD-5424-tidy-up-email-payloads branch 2 times, most recently from d1f62b2 to 43c4baf Compare September 12, 2024 13:28
@kevincarrogan kevincarrogan marked this pull request as ready for review September 12, 2024 13:33
markj0hnst0n
markj0hnst0n approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@markj0hnst0n markj0hnst0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had noticed those superfluous variables while doing some other notify stuff. Just double checked them on notify. Looks good.

@kevincarrogan kevincarrogan force-pushed the LTD-5424-tidy-up-email-payloads branch 2 times, most recently from 4b8e5d4 to ec83f0c Compare September 13, 2024 11:46
hnryjmes
hnryjmes reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@hnryjmes hnryjmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do I look at to confirm that these email types aren't being used?

@kevincarrogan
Copy link
Contributor Author

what do I look at to confirm that these email types aren't being used?

CTRL-F in the codebase for the removed payload classes.

@kevincarrogan kevincarrogan merged commit 05e43b7 into dev Sep 17, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hnryjmes hnryjmes hnryjmes approved these changes

@markj0hnst0n markj0hnst0n markj0hnst0n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevincarrogan @markj0hnst0n @hnryjmes